Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932627Ab0BCRH7 (ORCPT ); Wed, 3 Feb 2010 12:07:59 -0500 Received: from mta5.srv.hcvlny.cv.net ([167.206.4.200]:55030 "EHLO mta5.srv.hcvlny.cv.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932609Ab0BCRH5 (ORCPT ); Wed, 3 Feb 2010 12:07:57 -0500 Date: Wed, 03 Feb 2010 12:07:40 -0500 From: Michael Breuer Subject: Re: [PATCH] sky2: receive dma mapping error handling In-reply-to: <20100203085618.6662cc6f@nehalam> To: Stephen Hemminger Cc: Jarek Poplawski , David Miller , akpm@linux-foundation.org, flyboy@gmail.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Michael Chan , Don Fry , Francois Romieu , Matt Carlson Message-id: <4B69AD5C.5030601@majjas.com> MIME-version: 1.0 Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7BIT References: <20100128223447.GC3109@del.dom.local> <4B621316.8070308@majjas.com> <20100128225621.GD3109@del.dom.local> <4B6216B9.1010802@majjas.com> <20100128153643.0fca3c51@nehalam> <4B645EF4.4050701@majjas.com> <20100131003449.GA11935@del.dom.local> <4B650D53.2010607@majjas.com> <4B65D0F9.2020602@majjas.com> <4B65FD12.7090101@majjas.com> <20100131221835.GA3317@del.dom.local> <20100201102018.7b597992@nehalam> <4B68F664.6050007@majjas.com> <4B69A897.7030408@majjas.com> <20100203085618.6662cc6f@nehalam> User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.7) Gecko/20100120 Fedora/3.0.1-1.fc12 Thunderbird/3.0.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1198 Lines: 33 On 02/03/2010 11:56 AM, Stephen Hemminger wrote: > On Wed, 03 Feb 2010 11:47:19 -0500 > Michael Breuer wrote: > > >> Tracked this down. The status being returned is 0x3c0080 - good flow >> control packets. Nothing is actually being dropped (confirmed by packet >> trace on switch compared with packet trace on server). >> >> I whipped up a trivial patch to not count these as dropped packets and >> will post to netdev. >> >> I'm not really sure what the driver should be doing in this case, but >> resubmit seems to work. >> > Looks like a flow control negotiation issue. You probably turned off > flow control on the Linux side, but the switch is still doing flow > control. > > According to the driver: Feb 3 12:03:02 mail kernel: sky2 eth0: Link is up at 1000 Mbps, full duplex, flow control both So if the rx flow control packet status is due to flow control being disabled, then there's a different issue. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/