Date: Wed, 03 Feb 2010 18:00:56 -0800 (PST)
Message-Id: <20100203.180056.206222084.davem@davemloft.net>
To: Tristram.Ha@Micrel.Com
Cc: alan@lxorguk.ukuu.org.uk, shemminger@vyatta.com, netdev@vger.kernel.org,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.33 1/4] net: Micrel KSZ8841/2 PCI Ethernet driver
From: David Miller <davem@davemloft.net>
In-Reply-To: <14385191E87B904DBD836449AA30269D021A4D@MORGANITE.micrel.com>
References: <14385191E87B904DBD836449AA30269D021A4D@MORGANITE.micrel.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1103
Lines: 31

From: "Ha, Tristram" <Tristram.Ha@Micrel.Com>
Date: Fri, 29 Jan 2010 14:37:22 -0800

> This is a resubmission of the Micrel KSZ8841/2 PCI Ethernet driver.

The procfs stuff is a non-starter.

There will undoubtedly be other devices that have switch-like
facilities that we'd like to export configuration support for.

The last thing we want is a bunch of procfs files that each
driver decides the layout and behavior of.

We need a centralized way to config such things, and probably
the best is to have a rtnl_link_ops facility to get at the
ports and configure them with attribute blobs or similar.

We also said in your first submission that the way you're
getting at the bridge STP stuff with things like:

+/* Needed for STP support. */
+#ifdef CONFIG_KSZ8842_STP
+#include <../net/bridge/br_private.h>
+#endif

Yet you left all of this stuff in there.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/