Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754585Ab0BDGqX (ORCPT ); Thu, 4 Feb 2010 01:46:23 -0500 Received: from norsk5.dsl.xmission.com ([166.70.24.44]:50795 "EHLO master.douglaskthompson.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753516Ab0BDGqS (ORCPT ); Thu, 4 Feb 2010 01:46:18 -0500 Date: Wed, 03 Feb 2010 23:46:17 -0700 From: dougthompson@xmission.com To: kolifer@gmail.com, bluesmoke-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, akpm@linux-foundation.org Subject: [PATCH 6/7] edac: mpc85xx fsb ecc Message-ID: <4b6a6d39.qA/tt48S/7odhQ+i%dougthompson@xmission.com> User-Agent: Heirloom mailx 12.2 01/07/07 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1929 Lines: 47 From: Konstantin Olifer Patch is for Kernel 2.6.33. e752x_edac suppose that fsb ECC exist, for example, on Celeron + 3100. That is wrong. ECC FSB supported only on Xeon for our vision (www.setdsp.ru) and datasheet from developer intel www. Fixed. Signed-off-by: Konstantin Olifer Signed-off-by: Doug Thompson --- e752x_edac.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) Index: linux-2.6.33-rc4/drivers/edac/e752x_edac.c =================================================================== --- linux-2.6.33-rc4.orig/drivers/edac/e752x_edac.c 2010-01-12 23:26:07.000000000 -0700 +++ linux-2.6.33-rc4/drivers/edac/e752x_edac.c 2010-01-12 23:26:13.000000000 -0700 @@ -1073,10 +1073,7 @@ fail: /* Setup system bus parity mask register. * Sysbus parity supported on: - * e7320/e7520/e7525 + Xeon - * i3100 + Xeon/Celeron - * Sysbus parity not supported on: - * i3100 + Pentium M/Celeron M/Core Duo/Core2 Duo + * e7320/e7520/e7525 + Xeon */ static void e752x_init_sysbus_parity_mask(struct e752x_pvt *pvt) { @@ -1087,10 +1084,7 @@ static void e752x_init_sysbus_parity_mas /* Allow module parameter override, else see if CPU supports parity */ if (sysbus_parity != -1) { enable = sysbus_parity; - } else if (cpu_id[0] && - ((strstr(cpu_id, "Pentium") && strstr(cpu_id, " M ")) || - (strstr(cpu_id, "Celeron") && strstr(cpu_id, " M ")) || - (strstr(cpu_id, "Core") && strstr(cpu_id, "Duo")))) { + } else if (cpu_id[0] && !strstr(cpu_id, "Xeon")) { e752x_printk(KERN_INFO, "System Bus Parity not " "supported by CPU, disabling\n"); enable = 0; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/