Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757908Ab0BDNEc (ORCPT ); Thu, 4 Feb 2010 08:04:32 -0500 Received: from stinky.trash.net ([213.144.137.162]:44569 "EHLO stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755681Ab0BDNEb (ORCPT ); Thu, 4 Feb 2010 08:04:31 -0500 Message-ID: <4B6AC5DC.60301@trash.net> Date: Thu, 04 Feb 2010 14:04:28 +0100 From: Patrick McHardy User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20090701) MIME-Version: 1.0 To: Alexey Dobriyan CC: Jon Masters , Eric Dumazet , linux-kernel , netdev , netfilter-devel , "Paul E. McKenney" Subject: Re: [PATCH] netfilter: per netns nf_conntrack_cachep References: <1265108690.2861.118.camel@tonnant> <1265134598.2861.191.camel@tonnant> <4B6870AF.6060109@trash.net> <4B6967BC.600@trash.net> <1265222289.2861.290.camel@tonnant> <20100203190948.GA5182@x200> <1265226227.2861.302.camel@tonnant> <4B6ABCB8.4080904@trash.net> <4B6ABDEF.8090005@trash.net> In-Reply-To: X-Enigmail-Version: 0.95.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1397 Lines: 31 Alexey Dobriyan wrote: > On Thu, Feb 4, 2010 at 2:30 PM, Patrick McHardy wrote: >> Alexey Dobriyan wrote: >>> On Thu, Feb 4, 2010 at 2:25 PM, Patrick McHardy wrote: >>>> Jon Masters wrote: >>>>> On Wed, 2010-02-03 at 21:09 +0200, Alexey Dobriyan wrote: >>>>>> On Wed, Feb 03, 2010 at 01:38:09PM -0500, Jon Masters wrote: >>>>>>> *). Per namespace cacheing allocation (the cachep bits). We know it's >>>>>>> still possible for weirdness to happen in the SLAB cache here. >>>>>> Tiny race, needs reproducer. >>>>> Maybe. I think it's worth fixing anyway. >>>> Absolutely, I'll also apply Eric's patch with the %p fix for the >>>> slab name. >>> This would show kernel pointers in userspace ;-) >>> So, net->id is required. >> I don't see the problem. But yes, it would be nicer to have an ID. > > This is done (or rather, not done) to not show attackers > where data structures are. That's news to me, my /proc is full of kernel space pointers, including data. In any case, we need a fix for this suitable for 2.6.33. If you don't like using the pointer, please send a patch to add an id to the network namespaces. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/