Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758269Ab0BDNvx (ORCPT ); Thu, 4 Feb 2010 08:51:53 -0500 Received: from mail-fx0-f220.google.com ([209.85.220.220]:44065 "EHLO mail-fx0-f220.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750946Ab0BDNvv (ORCPT ); Thu, 4 Feb 2010 08:51:51 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:content-type :content-transfer-encoding; b=FFlYhVrpJbFVdbUG8Vzrst9ys2DqDDdcBcQw9JM2i4pr1gL93fiopOzsyyrsbhaR1f z+eRtX7/7KwI6KwyCnYP6+/cr6U3INbtkiFtBHP2Vqtl9Vchdo/EmcsnnD2tTGkqFShN ngBw2wfEIJIu/ATCH4Qgl3zLwFgRm0h+7HB/Y= Message-ID: <4B6AD0EE.9060801@gmail.com> Date: Thu, 04 Feb 2010 14:51:42 +0100 From: Jiri Slaby User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; cs-CZ; rv:1.9.1.7) Gecko/20100111 SUSE/3.0.1-9.1 Thunderbird/3.0.1 MIME-Version: 1.0 To: Mauro Carvalho Chehab CC: Jiri Kosina , Antti Palosaari , mchehab@infradead.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, Pekka Sarnila , linux-input@vger.kernel.org Subject: Re: [PATCH 1/1] media: dvb-usb/af9015, fix disconnection crashes References: <1264007972-6261-1-git-send-email-jslaby@suse.cz> <4B5CDB53.6030009@iki.fi> <4B5D6098.7010700@gmail.com> <4B5DDDFB.5020907@iki.fi> <4B6AA211.1060707@gmail.com> <4B6AB7E9.40607@redhat.com> <4B6AC333.6030308@gmail.com> <4B6ACEA3.3080900@redhat.com> In-Reply-To: <4B6ACEA3.3080900@redhat.com> X-Enigmail-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 816 Lines: 18 On 02/04/2010 02:41 PM, Mauro Carvalho Chehab wrote: > The point is that it is better to name the function right since the beginning. Sorry, I misunderstood you for the first time. It's .event member of hid_driver. Hence I named it dvb_event (or now rc_event or whatever). The function may contain decisions on what to do with the event based for example on quirks set up in .probe. And if the function grows later, it may be factored out to rc_nokeyup_event. But rc_event is a root for the decision tree and it should be there forever. Does it make sense now? -- js -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/