Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758282Ab0BDO13 (ORCPT ); Thu, 4 Feb 2010 09:27:29 -0500 Received: from mx1.redhat.com ([209.132.183.28]:64511 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758243Ab0BDO11 (ORCPT ); Thu, 4 Feb 2010 09:27:27 -0500 Message-ID: <4B6AD92E.5090905@redhat.com> Date: Thu, 04 Feb 2010 12:26:54 -0200 From: Mauro Carvalho Chehab User-Agent: Thunderbird 2.0.0.22 (X11/20090609) MIME-Version: 1.0 To: Jarod Wilson CC: Jiri Slaby , Jiri Kosina , Antti Palosaari , mchehab@infradead.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, Pekka Sarnila , linux-input@vger.kernel.org Subject: Re: [PATCH 1/1] media: dvb-usb/af9015, fix disconnection crashes References: <1264007972-6261-1-git-send-email-jslaby@suse.cz> <4B5CDB53.6030009@iki.fi> <4B5D6098.7010700@gmail.com> <4B5DDDFB.5020907@iki.fi> <4B6AA211.1060707@gmail.com> <4B6AB7E9.40607@redhat.com> <4B6AC333.6030308@gmail.com> <4B6ACEA3.3080900@redhat.com> <4B6C24FF.4050802@redhat.com> In-Reply-To: <4B6C24FF.4050802@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2619 Lines: 63 Jarod Wilson wrote: > On 02/04/2010 08:41 AM, Mauro Carvalho Chehab wrote: >> Jiri Slaby wrote: >>> On 02/04/2010 01:04 PM, Mauro Carvalho Chehab wrote: >>>>> I have 2 dvb-t receivers and both of them need fullspeed quirk. >>>>> Further >>>>> disable_rc_polling (a dvb_usb module parameter) must be set to not get >>>>> doubled characters now. And then, it works like a charm. >>>> Module parameters always bothers me. They should be used as last >>>> resort alternatives >>>> when there's no other possible way to make it work properly. >>>> >>>> If we know for sure that the RC polling should be disabled by an >>>> specific device, >>>> just add this logic at the driver. >>> >>> Yes, this is planned and written below: >> >> Ok. >>> >>>>> Note that, it's just some kind of proof of concept. A migration of >>>>> af9015 devices from dvb-usb-remote needs to be done first. >>>>> >>>>> Ideas, comments? >>>> Please next time, send the patch inlined. As you're using >>>> Thunderbird, you'll likely need >>>> Asalted-patches[1] to avoid thunderbird to destroy your patches. >>> >>> I must disagree for two reasons: (a) it was not patch intended for merge >>> and (b) it was a plain-text attachment which is fine even for >>> submission. However I don't like patches as attachments so if I decide >>> to submit it for a merge later, you will not see it as an attachment >>> then :). >> >> Attachments aren't good for reply, as they appear as a file. So, >> people need to >> open the attachment on a separate application to see and to cut-and-paste >> if they want to comment, like what I did. > > Just as an FYI... If you use mutt appropriately configured, it'll DTRT > with attached patches and let you reply with them quoted inline, and > actually, thunderbird 3 will more or less work with attached patches if > you do a select-all, then hit reply (tbird finally has 'quote selected > text' support). RHEL5 has Thunderbird 2, so, quote selected text doesn't work. I don't like very much to use text mailers, but i prefer the alpine interface. I never saw this feature in alpine. Maybe I just never managed to properly configure it there. Claws-mail has this feature, its monothread/monotask structure is very bad, since it stops answering to the edit window, if it starts to fetch new emails while you're editing an email. So, I stopped using it. -- Cheers, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/