Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1758496Ab0BDRbO (ORCPT <rfc822;w@1wt.eu>);
	Thu, 4 Feb 2010 12:31:14 -0500
Received: from mail-gx0-f224.google.com ([209.85.217.224]:38593 "EHLO
	mail-gx0-f224.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S933397Ab0BDRbE (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 4 Feb 2010 12:31:04 -0500
Message-ID: <4B6B0450.4000507@billgatliff.com>
Date: Thu, 04 Feb 2010 11:30:56 -0600
From: Bill Gatliff <bgat@billgatliff.com>
User-Agent: Thunderbird 2.0.0.23 (Macintosh/20090812)
MIME-Version: 1.0
To: H Hartley Sweeten <hartleys@visionengravers.com>
CC: linux-embedded@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PWM PATCH 1/5] API to consolidate PWM devices behind a common
 user and kernel interface
References: <cover.1265094517.git.bgat@billgatliff.com> <c5873aa7c5d20254a9e54fc1ff179345b77c16b5.1265094517.git.bgat@billgatliff.com> <BD79186B4FD85F4B8E60E381CAEE190902152ADB@mi8nycmail19.Mi8.com> <4B6A5BAA.2030908@billgatliff.com>
In-Reply-To: <4B6A5BAA.2030908@billgatliff.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1158
Lines: 37

Bill Gatliff wrote:
> H Hartley Sweeten wrote:
>   
>> Your older patch just used printk's to output the messages.  I think the
>> Oops is being caused by the dev_<level>(pwm->dev, ...).  Where is pwm->dev
>> being setup?
>>   
>>     
>
> The intention was to save the result from device_create() called from
> __pwm_create_sysfs(), but I'm suspicious that the patch I posted doesn't
> have that code for some reason.  My local git repo here doesn't seem to
> have it.  Hmmm...
>   

No, that's not right.  Disregard the above.

If the PWM device in question is already known to the kernel, then
before you call pwm_register() you must set pwm->dev to the address of
that device structure.  I need to come up with a better way to handle this.

If the PWM device isn't already known to the kernel as a true struct
device, then I don't yet have a Plan B.  Drat.  :(


b.g.

-- 
Bill Gatliff
bgat@billgatliff.com


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/