DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-type:content-disposition:in-reply-to:user-agent;
        b=Pa5TNzZAjXhde0zgFFg1mcPIwKTrYOJ75OF9fMpnhOejg0WKY0u0MSXCbZd993XFeG
         /4j9Ia3BF6JepT20VguFi+EpYDOdqf8OR3O/IBMYSRnr87VQqgnWpSoaEWqx4qN6Hq8A
         EwlUo8YidhD+QmqzKWeoUI8nzPeO/yhOq+Si0=
Date: Thu, 4 Feb 2010 10:41:32 -0800
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: Jiri Kosina <jkosina@suse.cz>, Antti Palosaari <crope@iki.fi>,
       mchehab@infradead.org, linux-kernel@vger.kernel.org,
       Mauro Carvalho Chehab <mchehab@redhat.com>, linux-media@vger.kernel.org,
       Pekka Sarnila <sarnila@adit.fi>, linux-input@vger.kernel.org
Subject: Re: [PATCH 1/1] media: dvb-usb/af9015, fix disconnection crashes
Message-ID: <20100204184132.GD10965@core.coreip.homeip.net>
References: <1264007972-6261-1-git-send-email-jslaby@suse.cz>
 <4B5CDB53.6030009@iki.fi>
 <4B5D6098.7010700@gmail.com>
 <4B5DDDFB.5020907@iki.fi>
 <alpine.LRH.2.00.1001261406010.15694@twin.jikos.cz>
 <4B6AA211.1060707@gmail.com>
 <20100204181404.GC10965@core.coreip.homeip.net>
 <4B6B12F2.2080102@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4B6B12F2.2080102@gmail.com>
User-Agent: Mutt/1.5.20 (2009-08-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1385
Lines: 37

On Thu, Feb 04, 2010 at 07:33:22PM +0100, Jiri Slaby wrote:
> On 02/04/2010 07:14 PM, Dmitry Torokhov wrote:
> > On Thu, Feb 04, 2010 at 11:31:45AM +0100, Jiri Slaby wrote:
> >  +
> >> +static int dvb_event(struct hid_device *hdev, struct hid_field *field,
> >> +		struct hid_usage *usage, __s32 value)
> >> +{
> >> +	/* we won't get a "key up" event */
> >> +	if (value) {
> >> +		input_event(field->hidinput->input, usage->type, usage->code, 1);
> >> +		input_event(field->hidinput->input, usage->type, usage->code, 0);
> > 
> > Do not ever forget input_sync(), you need 2 of them here.
> > 
> > With the latest changes to evdev, if you are using SIGIO you won't get
> > wioken up until EV_SYN/SYN_REPORT.
> 
> HID layer syncs on its own. So the second is not needed. Why is needed
> the first?
> 

Userpsace has a right to accumulate events and only act on them when
receiving EV_SYN. Press + release in the same event block may be treated
as no change. The same as REL_X +2, REL_X -2 - no need to move pointer at
all. And so on.

> I.e. should there be one also in dvb_usb_read_remote_control?

Probably, I have not looked.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/