Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933361Ab0BDU3M (ORCPT ); Thu, 4 Feb 2010 15:29:12 -0500 Received: from eddie.linux-mips.org ([78.24.191.182]:50155 "EHLO eddie.linux-mips.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932877Ab0BDU3K (ORCPT ); Thu, 4 Feb 2010 15:29:10 -0500 Date: Thu, 4 Feb 2010 21:25:07 +0100 From: Ralf Baechle To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Greg KH , linux-kernel@vger.kernel.org, Andrew Morton , David Brownell , Dmitri Vorobiev , Henrik Kretzschmar , James Bottomley , Kay Sievers , peter fuerst , Thomas Bogendoerfer Subject: Re: [PATCH 2/9] platform-drivers: move probe to .devinit.text in drivers/scsi Message-ID: <20100204202507.GA24912@linux-mips.org> References: <20100203150850.GA28815@kroah.com> <1265313417-5568-2-git-send-email-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1265313417-5568-2-git-send-email-u.kleine-koenig@pengutronix.de> User-Agent: Mutt/1.5.20 (2009-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 982 Lines: 24 On Thu, Feb 04, 2010 at 08:56:50PM +0100, Uwe Kleine-K?nig wrote: > A pointer to a probe callback is passed to the core via > platform_driver_register and so the function must not disappear when the > .init sections are discarded. Otherwise (if also having HOTPLUG=y) > unbinding and binding a device to the driver via sysfs will result in an > oops as does a device being registered late. > > An alternative to this patch is using platform_driver_probe instead of > platform_driver_register plus removing the pointer to the probe function > from the struct platform_driver. sgiwd93 bits looks good, so Acked-by: Ralf Baechle The IP22 hardware doesn't support hotplugging so this bug isn't dangerous. Ralf -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/