Date: Thu, 4 Feb 2010 22:31:58 +0100
From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= 
	<u.kleine-koenig@pengutronix.de>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: Greg KH <gregkh@suse.de>, linux-kernel@vger.kernel.org,
       Andrew Morton <akpm@linux-foundation.org>,
       David Brownell <dbrownell@users.sourceforge.net>,
       Dmitri Vorobiev <dmitri.vorobiev@movial.fi>,
       Henrik Kretzschmar <henne@nachtwindheim.de>,
       James Bottomley <James.Bottomley@HansenPartnership.com>,
       Kay Sievers <kay.sievers@vrfy.org>, peter fuerst <post@pfrst.de>,
       Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Subject: Re: [PATCH 2/9] platform-drivers: move probe to .devinit.text in
	drivers/scsi
Message-ID: <20100204213158.GB3035@pengutronix.de>
References: <20100203150850.GA28815@kroah.com> <1265313417-5568-2-git-send-email-u.kleine-koenig@pengutronix.de> <20100204202507.GA24912@linux-mips.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20100204202507.GA24912@linux-mips.org>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1322
Lines: 33

Hello,

On Thu, Feb 04, 2010 at 09:25:07PM +0100, Ralf Baechle wrote:
> On Thu, Feb 04, 2010 at 08:56:50PM +0100, Uwe Kleine-K?nig wrote:
> 
> > A pointer to a probe callback is passed to the core via
> > platform_driver_register and so the function must not disappear when the
> > .init sections are discarded.  Otherwise (if also having HOTPLUG=y)
> > unbinding and binding a device to the driver via sysfs will result in an
> > oops as does a device being registered late.
> > 
> > An alternative to this patch is using platform_driver_probe instead of
> > platform_driver_register plus removing the pointer to the probe function
> > from the struct platform_driver.
> 
> sgiwd93 bits looks good, so
> 
> Acked-by: Ralf Baechle <ralf@linux-mips.org>
> 
> The IP22 hardware doesn't support hotplugging so this bug isn't dangerous.
You can still trigger it via sysfs.  You need to be root though.

Best regards
Uwe

-- 
Pengutronix e.K.                              | Uwe Kleine-K?nig            |
Industrial Linux Solutions                    | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/