Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758616Ab0BDXTO (ORCPT ); Thu, 4 Feb 2010 18:19:14 -0500 Received: from p01c11o143.mxlogic.net ([208.65.144.66]:38558 "EHLO p01c11o143.mxlogic.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758475Ab0BDXTM convert rfc822-to-8bit (ORCPT ); Thu, 4 Feb 2010 18:19:12 -0500 X-MXL-Hash: 4b6b55f0441903f1-87b8e390ba0b1244754a1b287601c8d71c33c62b X-MimeOLE: Produced By Microsoft Exchange V6.5 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Subject: Re: [PATCH 2.6.33 1/4] net: Micrel KSZ8841/2 PCI Ethernet driver Date: Thu, 4 Feb 2010 15:18:54 -0800 Message-ID: <14385191E87B904DBD836449AA30269D021A51@MORGANITE.micrel.com> X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [PATCH 2.6.33 1/4] net: Micrel KSZ8841/2 PCI Ethernet driver Thread-Index: Acql8GuJFGGdevVDS6aRwlZCKMd9bw== From: "Ha, Tristram" To: "Dave Miller" Cc: "Alan Cox" , "Stephen Hemminger" , , X-OriginalArrivalTime: 04 Feb 2010 23:18:54.0903 (UTC) FILETIME=[6B934C70:01CAA5F0] X-Spam: [F=0.2000000000; CM=0.500; S=0.200(2010011101)] X-MAIL-FROM: X-SOURCE-IP: [65.218.208.2] X-AnalysisOut: [v=1.0 c=1 a=0RN4rdAoExkA:10 a=J3BOMSfJb05aRia9DmE+FQ==:17 ] X-AnalysisOut: [a=ATUHBX0TWO8JkiUIsMwA:9 a=YKM-8P-3Y5yaZvzim7IA:7 a=a8sOD-] X-AnalysisOut: [qGc6vbnySUOb6DrCzSpAkA:4] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1385 Lines: 32 Dave Miller wrote: >> This is a resubmission of the Micrel KSZ8841/2 PCI Ethernet driver. > > The procfs stuff is a non-starter. > > There will undoubtedly be other devices that have switch-like > facilities that we'd like to export configuration support for. > > The last thing we want is a bunch of procfs files that each > driver decides the layout and behavior of. > > We need a centralized way to config such things, and probably > the best is to have a rtnl_link_ops facility to get at the > ports and configure them with attribute blobs or similar. > > We also said in your first submission that the way you're > getting at the bridge STP stuff with things like: > > +/* Needed for STP support. */ > +#ifdef CONFIG_KSZ8842_STP > +#include <../net/bridge/br_private.h> > +#endif > Yet you left all of this stuff in there. In my discussions with Alan Cox and Stephen Hemminger, I thought they kind of agree to the code's inclusion in the driver. Sorry for my misunderstanding. I will submit another one with those code removed. P.S. I did not actually receive your response from my company's e-mail server. I copied it from LKML. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/