Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756739Ab0BEEG5 (ORCPT ); Thu, 4 Feb 2010 23:06:57 -0500 Received: from netrider.rowland.org ([192.131.102.5]:45328 "HELO netrider.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751150Ab0BEEG4 (ORCPT ); Thu, 4 Feb 2010 23:06:56 -0500 Date: Thu, 4 Feb 2010 23:06:53 -0500 (EST) From: Alan Stern X-X-Sender: stern@netrider.rowland.org To: Cong Wang cc: Peter Zijlstra , "Eric W. Biederman" , Greg KH , Thomas Gleixner , Kernel development list , Tejun Heo , Miles Lane , Heiko Carstens , Benjamin Herrenschmidt , Larry Finger , Andrew Morton Subject: Re: [Patch 0/2] sysfs: fix s_active lockdep warning In-Reply-To: <4B6B8BD5.8020404@redhat.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 765 Lines: 27 On Fri, 5 Feb 2010, Cong Wang wrote: > Alan Stern wrote: > > On Thu, 4 Feb 2010, Peter Zijlstra wrote: > > > >> On Thu, 2010-02-04 at 11:35 -0500, Alan Stern wrote: > >>> +#include > >> #include > >> > >> should be sufficient I think. > > > > No, it's not. It leaves MAX_LOCK_DEPTH undeclared. Beats me why that > > symbol ended up in sched.h... > > > > because task_struct->held_locks uses it, but it seems better to move > it into lockdep.h... Be my guest! :-) Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/