Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932771Ab0BEJak (ORCPT ); Fri, 5 Feb 2010 04:30:40 -0500 Received: from fg-out-1718.google.com ([72.14.220.156]:55542 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932408Ab0BEJaj (ORCPT ); Fri, 5 Feb 2010 04:30:39 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:to:cc:in-reply-to:references:content-type:date :message-id:mime-version:x-mailer:content-transfer-encoding; b=cSeKPtIZuWxRIGx2vrzLvW+1ff+hpnYzxrN1wJKv+WUeyHthtKeqYhZRV1dYRNgFC2 om6Ib5ZhLQMroZPgcBhoE5uX6KQvORv/5UooksLgukr7J1+8SZYgDFQQwujYZZrotqrB n/U4NyYYLZX/ChEeWPwJF9dL9e0FBlhTOdIXc= Subject: Re: [PATCH 13/17] MTD: export few functions from nand_base.c From: Maxim Levitsky To: "stanley.miao" Cc: David Woodhouse , Alex Dubov , Artem Bityutskiy , joern , linux-kernel , linux-mtd , Thomas Gleixner In-Reply-To: <4B6B8338.5060608@windriver.com> References: <1265326257-4446-1-git-send-email-maximlevitsky@gmail.com> <1265326257-4446-14-git-send-email-maximlevitsky@gmail.com> <4B6B8338.5060608@windriver.com> Content-Type: text/plain; charset="UTF-8" Date: Fri, 05 Feb 2010 11:30:34 +0200 Message-ID: <1265362234.15383.14.camel@maxim-laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 822 Lines: 25 On Fri, 2010-02-05 at 10:32 +0800, stanley.miao wrote: > Maxim Levitsky wrote: > > This exports: > > > > nand_do_read_oob > > nand_do_write_oob > > > > nand_do_read_oob and nand_do_write_oob can't be exported. They are internal > functions in NAND subsystem. If you want use them, please use mtd->read_oob > and mtd->write_oob. I would be happy to use these, and I tried to do so. However this leads to deadlock, because ->block_bad can (and is) called with controller lock (nand_get_device), thus if I call ->read_oob I will get deadlock. Best regards, Maxim Levitsky -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/