Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933129Ab0BEOR1 (ORCPT ); Fri, 5 Feb 2010 09:17:27 -0500 Received: from mail.dev.rtsoft.ru ([213.79.90.226]:51503 "HELO mail.dev.rtsoft.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S932962Ab0BEORZ (ORCPT ); Fri, 5 Feb 2010 09:17:25 -0500 X-Greylist: delayed 400 seconds by postgrey-1.27 at vger.kernel.org; Fri, 05 Feb 2010 09:17:25 EST Message-ID: <4B6C266D.6060209@ru.mvista.com> Date: Fri, 05 Feb 2010 17:08:45 +0300 From: Sergei Shtylyov User-Agent: Thunderbird 2.0.0.21 (X11/20090320) MIME-Version: 1.0 To: Christoph Egger CC: Jeff Garzik , Erik Inge Bols?? , Bartlomiej Zolnierkiewicz , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, vamos@i4.informatik.uni-erlangen.de, Alan Cox Subject: Re: [PATCH] non-existant config in kernel source (CONFIG_AHCI) References: <20100205132959.GB6874@faui49.informatik.uni-erlangen.de> In-Reply-To: <20100205132959.GB6874@faui49.informatik.uni-erlangen.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2299 Lines: 66 Hello. Christoph Egger wrote: > As part of the VAMOS[0] research project at the University of > Erlangen we're checking referential integrity between kernel KConfig > options and in-code Conditional blocks. > > While there's one place that is checking for CONFIG_AHCI, this > config being referenced from printed books and people pointing to this > config item I can't find it anywhere in the kernel kconfig > infrastruture and it doesn't seem to ever have been there (since > git). Is this maybe a typo for CONFIG_SATA_AHCI? reading the > information for the affected piece of source it would actually make > sense. > > Please keep me informed of this patch getting confirmed / > merged so we can keep track of it. > > Regards > > Christoph Egger > > [0] http://vamos1.informatik.uni-erlangen.de/ > > ---- > From 60136f94d9c97f9a788738e30731e25bd794322b Mon Sep 17 00:00:00 2001 > From: Christoph Egger > Date: Fri, 5 Feb 2010 13:26:33 +0100 > Subject: [PATCH] CONFIG_AHCI is really CONFIG_SATA_AHCI > > The marvell driver comtains a fallback to ahci for the sata ports > Only "contains". > which is incorrectly checked as CONFIG_AHCI while the only AHCI config > item is actually called SATA_AHCI (which also sounds sensible > considering it's a fallback for the sata ports). > > Signed-off-by: Christoph Egger > --- > drivers/ata/pata_marvell.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/ata/pata_marvell.c b/drivers/ata/pata_marvell.c > index 950da39..eabd138 100644 > --- a/drivers/ata/pata_marvell.c > +++ b/drivers/ata/pata_marvell.c > @@ -147,7 +147,7 @@ static int marvell_init_one (struct pci_dev *pdev, const struct pci_device_id *i > if (pdev->device == 0x6101) > ppi[1] = &ata_dummy_port_info; > > -#if defined(CONFIG_AHCI) || defined(CONFIG_AHCI_MODULE) > +#if defined(CONFIG_SATA_AHCI) || defined(SATA_CONFIG_AHCI_MODULE) > You surely meant CONFIG_SATA_AHCI_MODULE. WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/