Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757042Ab0BEQa3 (ORCPT ); Fri, 5 Feb 2010 11:30:29 -0500 Received: from mail-vw0-f46.google.com ([209.85.212.46]:36062 "EHLO mail-vw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756963Ab0BEQa2 (ORCPT ); Fri, 5 Feb 2010 11:30:28 -0500 MIME-Version: 1.0 In-Reply-To: References: Date: Fri, 5 Feb 2010 11:30:20 -0500 Message-ID: <7e0fb38c1002050830t6895d60dged9c7e1afd7eb56@mail.gmail.com> Subject: Re: [PATCH] inotify/fsnotify: tree-watching support From: Eric Paris To: Joris Dolderer Cc: linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 919 Lines: 24 On Fri, Feb 5, 2010 at 8:51 AM, Joris Dolderer wrote: > Hi, > > This is my first software submit, so please don't spare with detailed > constructive critics and be nice to me ;-). I would suggest that you take a careful look at Documentation/CodingStyle and Documentation/SubmittingPatches. There appear to be quite a number of issues which you may believe to be purely cosmetic or aesthetic but coding style and proper submission of patches are very important to keeping the kernel easy to maintain and develop further. I will try to take a look a the contents of the patch over the weekend and will give you some feedback. Thanks! -Eric -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/