Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933687Ab0BERwp (ORCPT ); Fri, 5 Feb 2010 12:52:45 -0500 Received: from senator.holtmann.net ([87.106.208.187]:46133 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752638Ab0BERwo (ORCPT ); Fri, 5 Feb 2010 12:52:44 -0500 Subject: Re: [PATCH] Bluetooth: Keep a copy of each HID device's report descriptor. From: Marcel Holtmann To: Michael Poole Cc: Bastien Nocera , Jiri Kosina , "Gunn, Brian" , Ping , linux-kernel@vger.kernel.org, BlueZ development In-Reply-To: <87vdebfvfk.fsf@troilus.org> References: <1264783166.29532.5302.camel@localhost.localdomain> <87iqakifm8.fsf@troilus.org> <1264860663.29532.7887.camel@localhost.localdomain> <871vh1gpaz.fsf_-_@troilus.org> <1265293390.31341.156.camel@localhost.localdomain> <87vdebfvfk.fsf@troilus.org> Content-Type: text/plain; charset="UTF-8" Date: Fri, 05 Feb 2010 09:51:43 -0800 Message-ID: <1265392303.31341.235.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.28.2 (2.28.2-1.fc12) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1137 Lines: 32 Hi Michael, > > looks good to me. I just prefer that you do the allocation of the report > > descriptor before the HID object: > > An updated patch is below. Sorry for the delay -- inclement weather > here got in the way of testing this as quickly as I would have liked. > > From e245ef87247f5e257db40c412af7991c9af375ab Mon Sep 17 00:00:00 2001 > From: Michael Poole > Date: Fri, 5 Feb 2010 12:21:38 -0500 > Subject: [PATCH] Bluetooth: Keep a copy of each HID device's report descriptor. > > The report descriptor is read by user space (via the Service > Discovery Protocol), so it is only available during the ioctl > to connect. However, the probe function that needs the > descriptor might not be called until a specific module is > loaded. Keep a copy of the descriptor so it is available for > later use. patch has been applied. Thanks. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/