Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934084Ab0BEX5Y (ORCPT ); Fri, 5 Feb 2010 18:57:24 -0500 Received: from g1t0026.austin.hp.com ([15.216.28.33]:31667 "EHLO g1t0026.austin.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933483Ab0BEX5X (ORCPT ); Fri, 5 Feb 2010 18:57:23 -0500 From: Bjorn Helgaas To: "Rafael J. Wysocki" Subject: Re: [PATCH 8/9] PCI / ACPI / PM: Platform support for PCI PME wake-up (rev. 7) Date: Fri, 5 Feb 2010 16:57:17 -0700 User-Agent: KMail/1.9.10 Cc: Jesse Barnes , "Moore, Robert" , Matthew Garrett , Len Brown , LKML , pm list , Linux PCI , Alan Stern , Oliver Neukum , Shaohua Li , Gary Hade References: <201001101431.38630.rjw@sisk.pl> <201001101501.03838.rjw@sisk.pl> In-Reply-To: <201001101501.03838.rjw@sisk.pl> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <201002051657.19754.bjorn.helgaas@hp.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1901 Lines: 42 On Sunday 10 January 2010 07:01:03 am Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > Although the majority of PCI devices can generate PMEs that in > principle may be used to wake up devices suspended at run time, > platform support is generally necessary to convert PMEs into wake-up > events that can be delivered to the kernel. If ACPI is used for this > purpose, a PME generated by a PCI device will trigger the ACPI GPE > associated with the device to generate an ACPI wake-up event that we > can set up a handler for, provided that everything is configured > correctly. I think acpiphp needs a little attention after this patch. Gary Hade noticed while testing Jesse's linux-next branch that acpiphp complains like this: acpiphp: ACPI Hot Plug PCI Controller Driver version: 0.5 acpiphp: Slot [9] registered acpiphp: Slot [10] registered acpiphp_glue: failed to register interrupt notify handler acpiphp: Slot [6] registered acpiphp_glue: failed to register interrupt notify handler I reproduced this on an HP rx3600 (ia64), and found that acpiphp doesn't complain on commit 82533a617f453, but it *does* complain on commit fb3383bb4ac6e, which seems to be this patch. I haven't tried to debug it any farther than just noticing that acpiphp starts complaining here, so I don't know what the right fix is, or even if acpiphp is really broken. I did use acpiphp to power-cycle a slot ("echo 0 > power"), and it seemed to work despite the warnings. But I guess the notification is probably not involved in that path; I suppose the notification is like a latch or attention button interrupt or something. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/