Date: Sun, 7 Feb 2010 23:56:50 +0000
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Joonyoung Shim <jy0922.shim@samsung.com>
Cc: lrg@slimlogic.co.uk, linux-kernel@vger.kernel.org,
       kyungmin.park@samsung.com
Subject: Re: [PATCH] regulator: Add enable_time on probe of WM8994
Message-ID: <20100207235650.GA14408@opensource.wolfsonmicro.com>
References: <4B6E0C36.3090608@samsung.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4B6E0C36.3090608@samsung.com>
User-Agent: Mutt/1.5.17+20080114 (2008-01-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1006
Lines: 19

On Sun, Feb 07, 2010 at 09:41:26AM +0900, Joonyoung Shim wrote:
> WM8994 regulator needs some delay to enable when it is probed too.

What is the problem that's fixed by this change?

The only case I can think of where it would help is if the regulator
constraints are used to enable the regulators and run them at a
non-default voltage.  (which is not a recommended configuration since
this would mean raising the voltage and therefore increasing power
consumption).  For that case this is not quite enough of a change since
the LDO that is being controlled may not be the one that brings the
device out of power on reset.  More extensive rearrangement of the core
regulator code would be required to deal with that, reordering the
application of constraints.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/