Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753004Ab0BHOvf (ORCPT ); Mon, 8 Feb 2010 09:51:35 -0500 Received: from iolanthe.rowland.org ([192.131.102.54]:45457 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752890Ab0BHOvd (ORCPT ); Mon, 8 Feb 2010 09:51:33 -0500 Date: Mon, 8 Feb 2010 09:51:33 -0500 (EST) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Christoph Egger cc: linux-kernel@vger.kernel.org, , , Subject: Re: [PATCH] obsolete config in kernel source (USB_GADGET_*) In-Reply-To: <20100205122412.GA6540@faui49.informatik.uni-erlangen.de> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1444 Lines: 34 On Fri, 5 Feb 2010, Christoph Egger wrote: > On Fri, Jan 15, 2010 at 09:46:00AM -0500, Alan Stern wrote: > > On Fri, 15 Jan 2010, Christoph Egger wrote: > > > The linux tree contains USB-Id assignment snippets for some > > > USB Gadget drivers, which, as far as I can tell, never worked on > > > mainline linux2.6 but either originate from seemingly long-dead > > > third-party trees or were never ported from linux2.4. > > > > > > As there has also seemingly never existed a way to select > > > these configs in the KConfig system it might be time to get rid of > > > them which would be done by the attached patch. > > > > Have you tried building g_file_storage and the other gadget drivers > > after applying your patch? > > You're right. I ony checked whether the first few were still > needed somewhere in code and assumed equal status for all of > them. SHould have at least build-tested all that stuff before sending > (and doing so now). > > Below is a updated patch that should be more correct and does > also build (tested against mainline git). The new patch looks okay to me. Other people might have opinions about whether this code should be removed, however. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/