Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753422Ab0BHSNp (ORCPT ); Mon, 8 Feb 2010 13:13:45 -0500 Received: from mail-fx0-f215.google.com ([209.85.220.215]:40003 "EHLO mail-fx0-f215.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750962Ab0BHSNn convert rfc822-to-8bit (ORCPT ); Mon, 8 Feb 2010 13:13:43 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=TQU5aafap5Alfvjejaq7KHarHciiIfEjr7CQsoYdyXdHvUa1onV+7hIrUfLsylA4Ik AJafEONaHa4s5pzYip2S6T9VcTuLfgWG9m7mcUr9qn6+84f7Bsk4n8FyEyU/jKe3bwWS ivttKK8fpVZU41vlAFiLQ5kifNbI23jeJX/7Y= MIME-Version: 1.0 In-Reply-To: References: <45c77aec1002071056re61b8acg5f480f8ea83c68c@mail.gmail.com> Date: Mon, 8 Feb 2010 13:13:40 -0500 Message-ID: <45c77aec1002081013q2b07cb7flbd827a977ed51d4c@mail.gmail.com> Subject: Re: Possible bug in insmod or the kernel? From: Larry Homes To: andrew hendry Cc: linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2229 Lines: 54 No, the problem is not that the quotes are showing. The problem is that as soon as it sees a space, it assumes the following is the next parameters name. So for example: [root@myhost modules]# insmod hello3.ko name="john smith" insmod: error inserting 'hello3.ko': -1 Unknown symbol in module [root@myhost modules]# insmod hello3.ko "name=john smith" insmod: error inserting 'hello3.ko': -1 Unknown symbol in module In both cases, dmesg shows: hello3: Unknown parameter `smith' I looked at the params.c code and it seems like the above should work. On Sun, Feb 7, 2010 at 5:14 PM, andrew hendry wrote: > have a look around kernel/params.c > /* You can use " around spaces, but can't escape ". */ > /* Hyphens and underscores equivalent in parameter names. */ > static char *next_arg(char *args, char **param, char **val) > > Your printks are probably showing the single quotes? probably not what > you want in your name > > On Mon, Feb 8, 2010 at 5:56 AM, Larry Homes wrote: >> Hello, >> >> I am very new to kernel development and I was playing around with >> making modules. I found I could not retrieve commandline parameters in >> the module if the parameter has whitespace in it. I thought it was my >> lack of knowledge that was causing the error (and I still do >> honestly), but I made a forum post here >> http://forum.kernelnewbies.org/read.php?17,1354 regarding the issue, >> and someone suggested it may be a bug and I should post on LKML. >> >> The forum post shows example code to demonstrate the issue. I am using >> archlinux and the latest kernel. I am not sure what other information >> you need, so feel free to ask for anything. >> >> >> Thanks >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at ?http://vger.kernel.org/majordomo-info.html >> Please read the FAQ at ?http://www.tux.org/lkml/ >> > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/