Date: Mon, 8 Feb 2010 14:06:48 -0800
From: Andrew Morton <akpm@linux-foundation.org>
To: Dave Young <hidave.darkstar@gmail.com>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH 1/2] printk delay for each line break instead of
 callback
Message-Id: <20100208140648.3c38d909.akpm@linux-foundation.org>
In-Reply-To: <20100206133425.GA2562@darkstar>
References: <20100206133425.GA2562@darkstar>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1765
Lines: 49

On Sat, 6 Feb 2010 21:34:25 +0800
Dave Young <hidave.darkstar@gmail.com> wrote:

> printk delay for every callback does not make sense, change to delay every line
> 
> Signed-off-by: Dave Young <hidave.darkstar@gmail.com>
> ---
> 
>  kernel/printk.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-2.6.orig/kernel/printk.c	2010-02-02 13:38:47.646659531 +0800
> +++ linux-2.6/kernel/printk.c	2010-02-02 13:39:19.446657319 +0800
> @@ -678,7 +678,6 @@ asmlinkage int vprintk(const char *fmt, 
>  	char *p;
>  
>  	boot_delay_msec();
> -	printk_delay();
>  
>  	preempt_disable();
>  	/* This stops the holder of console_sem just where we want him */
> @@ -746,6 +745,7 @@ asmlinkage int vprintk(const char *fmt, 
>  	 */
>  	for ( ; *p; p++) {
>  		if (new_text_line) {
> +			printk_delay();
>  			/* Always output the token */
>  			emit_log_char('<');
>  			emit_log_char(current_log_level + '0');

This moves the printk_delay() so that it is now inside
spin_lock_irqsave(logbuf_lock).

This fixes the race I mentioned in the previous email, but it seems a
bad idea.  If the delay is long enough, it could even cause other CPUs
to get hit by the NMI watchdog when trying to acquire logbuf_lock.

A better approach would be to perform the calculation of "how long must
I delay" at this site, but perform the actual delay later, after the
raw_local_irq_restore().  This means that if the printk contains
"a\nb\nc\n" then we won't delay until the final \n, but that seems a
fairly small problem.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/