Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752954Ab0BHW4l (ORCPT ); Mon, 8 Feb 2010 17:56:41 -0500 Received: from rcsinet11.oracle.com ([148.87.113.123]:47006 "EHLO rcsinet11.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752395Ab0BHW4k (ORCPT ); Mon, 8 Feb 2010 17:56:40 -0500 Date: Mon, 8 Feb 2010 14:56:05 -0800 From: Randy Dunlap To: Hugh Dickins Cc: Eric B Munson , akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-man@vger.kernel.org, mtk.manpages@gmail.com, Arnd Bergman Subject: Re: [PATCH] Fix for hugetlb-add-map_hugetlb-for-mmaping-pseudo-anonymous-huge-page-regions.patch in -mm Message-Id: <20100208145605.5eea30b5.randy.dunlap@oracle.com> In-Reply-To: References: <1252487811-9205-1-git-send-email-ebmunson@us.ibm.com> <1253011613-6429-1-git-send-email-ebmunson@us.ibm.com> Organization: Oracle Linux Eng. X-Mailer: Sylpheed 2.6.0 (GTK+ 2.16.6; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Source-IP: acsmt354.oracle.com [141.146.40.154] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090204.4B709697.0238:SCFMA4539814,ss=1,fgs=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2300 Lines: 54 On Tue, 15 Sep 2009 21:53:12 +0100 (BST) Hugh Dickins wrote: > On Tue, 15 Sep 2009, Eric B Munson wrote: > > Resending because this seems to have fallen between the cracks. > > Yes, indeed. I think it isn't quite what Arnd was suggesting, but I > agree with you that we might as well go for 0x080000 (so that even Alpha > can be just a cut-and-paste job from asm-generic), and right now it's > more important to finalize the number than what file it appears in. > > Acked-by: Hugh Dickins so what happened with this patch ?? > > > > The patch > > hugetlb-add-map_hugetlb-for-mmaping-pseudo-anonymous-huge-page-regions.patch > > used the value 0x40 for MAP_HUGETLB which is the same value used for > > various other flags on some architectures. This collision causes > > unexpected use of huge pages in the best case and mmap to fail with > > ENOMEM or ENOSYS in the worst. This patch changes the value for > > MAP_HUGETLB to a value that is not currently used on any arch. > > > > This patch should be considered a fix to > > hugetlb-add-map_hugetlb-for-mmaping-pseudo-anonymous-huge-page-regions.patch. > > > > Reported-by: Hugh Dickins > > Signed-off-by: Eric B Munson > > --- > > include/asm-generic/mman-common.h | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/include/asm-generic/mman-common.h b/include/asm-generic/mman-common.h > > index 12f5982..e6adb68 100644 > > --- a/include/asm-generic/mman-common.h > > +++ b/include/asm-generic/mman-common.h > > @@ -19,7 +19,7 @@ > > #define MAP_TYPE 0x0f /* Mask for type of mapping */ > > #define MAP_FIXED 0x10 /* Interpret addr exactly */ > > #define MAP_ANONYMOUS 0x20 /* don't use a file */ > > -#define MAP_HUGETLB 0x40 /* create a huge page mapping */ > > +#define MAP_HUGETLB 0x080000 /* create a huge page mapping */ > > > > #define MS_ASYNC 1 /* sync memory asynchronously */ > > #define MS_INVALIDATE 2 /* invalidate the caches */ > > -- --- ~Randy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/