DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        b=C3mKIEsT5IoNiXzfFkjosUlXq+ZMA7bv91MYkSmlRuppZvgMrl/Zd8dKMi5kHTUkp6
         OUB02DOdjsrYez3M7pmwoUsjAfvks4iAZjwxmDWoygxpseYU8+AXPRSzztXDzbfUJnSk
         EH874GSGKIXBD2aHNDGEO9LhCtKFHEbs2Yhvs=
MIME-Version: 1.0
In-Reply-To: <20100208140127.ca80bc97.akpm@linux-foundation.org>
References: <20100206134056.GB2562@darkstar>
	 <20100208135654.04b79bbc.akpm@linux-foundation.org>
	 <20100208140127.ca80bc97.akpm@linux-foundation.org>
Date: Tue, 9 Feb 2010 10:35:04 +0800
Message-ID: <a8e1da1002081835m789168f7h73f1709e69228b15@mail.gmail.com>
Subject: Re: [PATCH 2/2] allow printk delay after multi lines
From: Dave Young <hidave.darkstar@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 3222
Lines: 89

On Tue, Feb 9, 2010 at 6:01 AM, Andrew Morton <akpm@linux-foundation.org> wrote:
> On Mon, 8 Feb 2010 13:56:54 -0800
> Andrew Morton <akpm@linux-foundation.org> wrote:
>
>> On Sat, 6 Feb 2010 21:40:56 +0800
>> Dave Young <hidave.darkstar@gmail.com> wrote:
>>
>> > printk delay help us to capture printk messages on some unconvenient senarios,
>> > but it is still not easy to read.
>> >
>> > Add another sysctl variable printk_delay_per_lines to make it more readable.
>> > We can set the lines according to screen height, then take pictures by camera.
>> >
>> > kmesg will delay printk_delay_per_lines * printk_delay_msecs milliseconds
>> > after every printk_delay_per_lines lines when printk_delay is enabled.
>> >
>> > Setting the lines by proc/sysctl interface:
>> > /proc/sys/kernel/printk_delay_per_lines
>> >
>> > Andrew, sorry, I have not find time to cleanup the kernel.h sysctl variables.
>> > If I'm free I will try to do it.
>> >
>> > The value range from 1 - 100, default value is 1
>> >
>> > ...
>> >
>> > --- linux-2.6.orig/include/linux/kernel.h   2010-02-02 13:38:09.537495564 +0800
>> > +++ linux-2.6/include/linux/kernel.h        2010-02-02 13:40:47.657480122 +0800
>> > @@ -246,6 +246,7 @@ extern bool printk_timed_ratelimit(unsig
>> >                                unsigned int interval_msec);
>> >
>> >  extern int printk_delay_msec;
>> > +extern int printk_delay_per_lines;
>> >
>> >  /*
>> >   * Print a one-time message (analogous to WARN_ONCE() et al):
>> > --- linux-2.6.orig/kernel/printk.c  2010-02-02 13:39:19.446657319 +0800
>> > +++ linux-2.6/kernel/printk.c       2010-02-02 13:40:47.660813615 +0800
>> > @@ -656,16 +656,26 @@ static int new_text_line = 1;
>> >  static char printk_buf[1024];
>> >
>> >  int printk_delay_msec __read_mostly;
>> > +int printk_delay_per_lines __read_mostly;
>> >
>> >  static inline void printk_delay(void)
>> >  {
>> >     if (unlikely(printk_delay_msec)) {
>> > -           int m = printk_delay_msec;
>> > +           static int m, l;
>> >
>> > +           if (!l)
>> > +                   l = printk_delay_per_lines;
>> > +
>> > +           if (--l) {
>> > +                   m += printk_delay_msec;
>> > +                   return;
>> > +           }
>> > +           m += printk_delay_msec;
>> >             while (m--) {
>> >                     mdelay(1);
>> >                     touch_nmi_watchdog();
>> >             }
>> > +           m = 0;
>> >     }
>> >  }
>>
>
> Also...
>
> - The above code is racy: if multiple CPUs run printk_delay()
>  concurrently, `m' and `l' will get mucked up.
>
>  We should verify that the effects of this race are benign.  This
>  will be hard.
>
>  Or we fix the race.  One could add locking (irq-safe locking), but
>  I suspect a better approach would be to use atomic ops.
>

will change to  use atomic ops

-- 
Regards
dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/