Date: Mon, 8 Feb 2010 21:36:43 -0800
From: Arjan van de Ven <arjan@infradead.org>
To: chihau Chau <chihau@gmail.com>
Cc: bfields@fieldses.org, neilb@suse.de, viro@zeniv.linux.org.uk,
       Trond.Myklebust@netapp.com, bharrosh@panasas.com,
       akpm@linux-foundation.org, linux-nfs@vger.kernel.org,
       linux-kernel@vger.kernel.org, Chihau Chau <chihau@gmail.com>
Subject: Re: [PATCH] fs: nfsd: export: fix coding style issues
Message-ID: <20100208213643.540d92a4@infradead.org>
In-Reply-To: <1265665013-32162-1-git-send-email-chihau@gmail.com>
References: <1265665013-32162-1-git-send-email-chihau@gmail.com>
Organization: Intel
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 799
Lines: 15

> -static struct svc_expkey *svc_expkey_update(struct svc_expkey *new, struct svc_expkey *old); 
> +static struct svc_expkey *svc_expkey_update(struct svc_expkey *new,
> +							struct svc_expkey *old); 


how is this an improvement ? I don't find the 2nd more more readable

also, are you planning to do real changes to this file? If not, I would suggest not doing cleanups like this;
while cleanups like the other things you did are fine as a first step to doing real work on a file, it's usually
not liked very much to ONLY do such cosmetic things...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/