Date: Mon, 8 Feb 2010 22:07:53 -0800
From: Andrew Morton <akpm@linux-foundation.org>
To: Dave Young <hidave.darkstar@gmail.com>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH 2/2] allow printk delay after multi lines
Message-Id: <20100208220753.61a39bab.akpm@linux-foundation.org>
In-Reply-To: <a8e1da1002082156s3145a775o7424bc47ac503636@mail.gmail.com>
References: <20100206134056.GB2562@darkstar>
	<20100208135654.04b79bbc.akpm@linux-foundation.org>
	<a8e1da1002081831j6fdea8a7v41cc07b635ab7dda@mail.gmail.com>
	<a8e1da1002082156s3145a775o7424bc47ac503636@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1169
Lines: 28

On Tue, 9 Feb 2010 13:56:34 +0800 Dave Young <hidave.darkstar@gmail.com> wrote:

> BTW, for the sysctl variables. I found in kernel.h there's:
> printk/console_loglevel/panic related extern variables for sysctl.
> 
> console_loglevel and panic related variables are used here and there,
> not just for sysctl, so I think it should stay in kernel.h.
> 
> The printk related variables for sysctl and all the extern variables in
> sysctl.c can be move to sysctl.h. Seems no need new head file.
> 
> Andrew, what's your opinion?

Symbols which are defined in printk.c and which are used in other
compilation units should be declared in printk.h!

We mucked up in the past by putting these things in kernel.h and as
externs in sysctl.c, but that's no reason to continue to do so.  As a
special-case, it makes convenience sense to declare printk() itself and
the loglevel strings etc in kernel.h, but that _is_ a special case.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/