Date: Wed, 10 Feb 2010 13:22:01 -0800 (PST)
Message-Id: <20100210.132201.21689811.davem@davemloft.net>
To: maximlevitsky@gmail.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
       maxim-levitsky@gmail.com
Subject: Re: [PATCH 2/6] DMFE: move pci ID definitions into pci_ids.h and
 clean up the code
From: David Miller <davem@davemloft.net>
In-Reply-To: <20100210.131849.237007566.davem@davemloft.net>
References: <1265487542-4447-1-git-send-email-maximlevitsky@gmail.com>
	<1265487542-4447-3-git-send-email-maximlevitsky@gmail.com>
	<20100210.131849.237007566.davem@davemloft.net>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1224
Lines: 35

From: David Miller <davem@davemloft.net>
Date: Wed, 10 Feb 2010 13:18:49 -0800 (PST)

> From: Maxim Levitsky <maximlevitsky@gmail.com>
> Date: Sat,  6 Feb 2010 22:18:58 +0200
> 
>> Signed-off-by: Maxim Levitsky <maxim-levitsky@gmail.com>
> 
> We don't add new definitions to pci_ids.h that will only
> be used in a single driver.
> 
> Instead, we just use the raw constants (if it's only referenced once,
> say in the PCI ID table for the driver) or using local definitions
> (if used multiple times in the driver).

BTW, the rest of your patch set is likely to not apply
correctly after you fix this patch up.  So at a minimum
you'll need to resubmit this whole set after fixing
patch #2.

In fact I would recommend that you seperate the bug
fixes from all of the massive cleanups.

Get the bug fixes, especially the PCI READ MULTIPLE
disable one, into net-2.6

Then afterwards you can do all of the cleanups against
net-next-2.6 when the bug fixes propagate there.

Thank you!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/