From: Thomas Renninger <trenn@suse.de>
Organization: SUSE Products GmbH
To: Julia Lawall <julia@diku.dk>
Subject: Re: [PATCH] drivers/acpi/processor_thermal.c
Date: Thu, 11 Feb 2010 12:04:50 +0100
User-Agent: KMail/1.12.2 (Linux/2.6.32.1-0.0.14.f17927a-desktop; KDE/4.3.1; x86_64; ; )
Cc: Darren Jenkins <darrenrjenkins@gmail.com>, Len Brown <lenb@kernel.org>,
       Zhang Rui <rui.zhang@intel.com>,
       H Hartley Sweeten <hsweeten@visionengravers.com>,
       Andrew Morton <akpm@linux-foundation.org>,
       linux ACPI <linux-acpi@vger.kernel.org>,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
       Kernel Janitors <kernel-janitors@vger.kernel.org>
References: <1265882211.27789.1.camel@ICE-BOX> <201002111124.51070.trenn@suse.de> <Pine.LNX.4.64.1002111150510.2412@ask.diku.dk>
In-Reply-To: <Pine.LNX.4.64.1002111150510.2412@ask.diku.dk>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201002111204.50843.trenn@suse.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1085
Lines: 39

On Thursday 11 February 2010 11:52:20 Julia Lawall wrote:
> On Thu, 11 Feb 2010, Thomas Renninger wrote:
> 
> > Eh, 
> > 
> > what is this for?:
> > static inline void *acpi_driver_data(struct acpi_device *d)
> > {
> >         return d->driver_data;
> > }
...
> 
> A potential patch that gets rid of the uses is below.  I don't have time 
> to look at this in more detail at the moment, but perhaps someone else 
> would like to do so.  The semantic patch (http://coccinelle.lip6.fr) 
> involved is:
> 
> @@
> struct acpi_device *d;
> @@
> 
> - acpi_driver_data(d)
> + d->driver_data
Len, do you mind adding this to your test branch, please.
I can grep over it afterwards (somewhen...) and void out
acpi_driver_data(..)
declaration in acpi_bus.h.

I expect also Darren has to rebase his fixes on top of this
one then.

Thanks,

     Thomas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/