Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755960Ab0BKPcM (ORCPT ); Thu, 11 Feb 2010 10:32:12 -0500 Received: from iolanthe.rowland.org ([192.131.102.54]:47223 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1755377Ab0BKPcK (ORCPT ); Thu, 11 Feb 2010 10:32:10 -0500 Date: Thu, 11 Feb 2010 10:32:08 -0500 (EST) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: "Rafael J. Wysocki" cc: Stephen Rothwell , , Subject: Re: linux-next: build warning after merge of the suspend tree In-Reply-To: <201002111411.35634.rjw@sisk.pl> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1066 Lines: 27 On Thu, 11 Feb 2010, Rafael J. Wysocki wrote: > On Thursday 11 February 2010, Stephen Rothwell wrote: > > Hi Rafael, > > > > After merging the suspend tree, today's linux-next build (powerpc > > ppc64_defconfig) produced this warning: > > > > drivers/usb/core/hcd-pci.c:138: warning: 'wait_for_companions' defined but not used > > > > Introduced by commit ce74abf51a15ab82a9fae6dcd8a9c0038945f10e ("USB: > > implement non-tree resume ordering constraints for PCI host controllers"). > > Thanks for the info, I'll fix this up later today in my tree. Clearly wait_for_companions() needs to be inside "#ifdef CONFIG_PM_SLEEP ... #endif". In fact, all the new functions added by the patch should be protected this way, with suitable do-nothing inline versions provided when CONFIG_PM_SLEEP isn't defined. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/