Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755898Ab0BKRBi (ORCPT ); Thu, 11 Feb 2010 12:01:38 -0500 Received: from xenotime.net ([72.52.64.118]:42616 "HELO xenotime.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752982Ab0BKRBh (ORCPT ); Thu, 11 Feb 2010 12:01:37 -0500 Message-ID: <4B7437EF.2050001@xenotime.net> Date: Thu, 11 Feb 2010 09:01:35 -0800 From: Randy Dunlap Organization: YPO4 User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091209 Fedora/3.0-3.fc11 Thunderbird/3.0 MIME-Version: 1.0 To: Dan Carpenter , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: bug list: putting too much data on the stack References: <20100211085120.GF14210@bicker> In-Reply-To: <20100211085120.GF14210@bicker> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1462 Lines: 41 On 02/11/10 00:51, Dan Carpenter wrote: > This is a list of functions that put a lot of data (500 bytes) on the stack. > I don't know if 500 is reasonable, but I've seen people complaining about > smaller amounts. > > The list was generated by: > make C=1 CHECK="/path/to/smatch -p=kernel" modules bzImage | tee warns.txt > grep "bytes on stack" warns.txt > > regards, > dan carpenter > > Previous bug lists: > * Assigning negative values to unsigned variables > http://lkml.indiana.edu/hypermail/linux/kernel/1001.3/01222.html > > * Doing dma on the stack > http://lkml.indiana.edu/hypermail/linux/kernel/1001.3/01231.html > > * Dereferencing variables before verifying they are not null > http://lkml.indiana.edu/hypermail/linux/kernel/1001.3/01980.html > ... > drivers/media/dvb/frontends/dib3000mc.c +816 dib3000mc_i2c_enumeration(2) warn: 'st' puts 1416 bytes on stack > drivers/media/dvb/frontends/dib7000p.c +1326 dib7000p_i2c_enumeration(2) warn: 'st' puts 1468 bytes on stack I posted patches for these a few days ago. Andrew put them into mmotm. linux-media hasn't responded to them yet. http://patchwork.kernel.org/patch/77892/ http://patchwork.kernel.org/patch/77891/ -- ~Randy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/