Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756885Ab0BKTXP (ORCPT ); Thu, 11 Feb 2010 14:23:15 -0500 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.123]:45351 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756817Ab0BKTXN (ORCPT ); Thu, 11 Feb 2010 14:23:13 -0500 X-Authority-Analysis: v=1.0 c=1 a=I-JJUczq-h8A:10 a=7U3hwN5JcxgA:10 a=I6mivPKuZD-2YloFHtgA:9 a=0smg61dRb8mc1Tiu5i_x0vV9RAoA:4 X-Cloudmark-Score: 0 X-Originating-IP: 74.67.89.75 Subject: Re: [PATCH 02/11] tracing: Introduce TRACE_EVENT_INJECT From: Steven Rostedt Reply-To: rostedt@goodmis.org To: Frederic Weisbecker Cc: Peter Zijlstra , Ingo Molnar , LKML , Arnaldo Carvalho de Melo , Paul Mackerras , Hitoshi Mitake , Li Zefan , Lai Jiangshan , Masami Hiramatsu , Jens Axboe In-Reply-To: <20100211185744.GD4915@nowhere> References: <1265188475-23509-1-git-send-regression-fweisbec@gmail.com> <1265188475-23509-3-git-send-regression-fweisbec@gmail.com> <1265381266.24386.32.camel@gandalf.stny.rr.com> <1265381604.22001.682.camel@laptop> <1265382452.24386.38.camel@gandalf.stny.rr.com> <20100206122004.GF5062@nowhere> <1265462370.4561.12179.camel@frodo> <20100210100440.GA5035@nowhere> <1265810706.24386.58.camel@gandalf.stny.rr.com> <20100211185744.GD4915@nowhere> Content-Type: text/plain; charset="ISO-8859-15" Organization: Kihon Technologies Inc. Date: Thu, 11 Feb 2010 14:23:06 -0500 Message-ID: <1265916186.24271.9.camel@gandalf.stny.rr.com> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1013 Lines: 27 On Thu, 2010-02-11 at 19:57 +0100, Frederic Weisbecker wrote: > On Wed, Feb 10, 2010 at 09:05:06AM -0500, Steven Rostedt wrote: > > Looking back at where trace_lock_class_init() was placed, you don't need > > a wrapper. But instead, why not just have perf hook directly into the > > trace_lock_class_init trace point, and do its injection directly. > > Instead of needing to add some hack to TRACE_EVENT()? > > > We could. But we expect further events may need such catch-up by > injection system. And ftrace will also need to perform this injection. > > That's why I think something more generic would be more reasonable. > Hmm, I'm a bit dense lately and still a bit confused. Why is an injector needed exactly, and why would ftrace want one too? -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/