Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751434Ab0BLFax (ORCPT ); Fri, 12 Feb 2010 00:30:53 -0500 Received: from chilli.pcug.org.au ([203.10.76.44]:43450 "EHLO smtps.tip.net.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750805Ab0BLFav (ORCPT ); Fri, 12 Feb 2010 00:30:51 -0500 Date: Fri, 12 Feb 2010 16:30:42 +1100 From: Stephen Rothwell To: "Jun'ichi Nomura" Cc: Andrew Morton , Al Viro , Valdis.Kletnieks@vt.edu, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-s390@vger.kernel.org, linux-next@vger.kernel.org, Heiko Carstens Subject: Re: mmotm 2010-02-10 - BUG at fs/dcache.c:677! Message-Id: <20100212163042.da2fb31d.sfr@canb.auug.org.au> In-Reply-To: <4B74DE40.5030401@ce.jp.nec.com> References: <201002110043.o1B0hKxW008835@imap1.linux-foundation.org> <8576.1265942657@localhost> <20100211191427.6ff9aec6.akpm@linux-foundation.org> <4B74DE40.5030401@ce.jp.nec.com> X-Mailer: Sylpheed 3.0.0beta7 (GTK+ 2.18.6; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg="PGP-SHA1"; boundary="Signature=_Fri__12_Feb_2010_16_30_42_+1100_EI7capKdFqWUTW+I" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2010 Lines: 58 --Signature=_Fri__12_Feb_2010_16_30_42_+1100_EI7capKdFqWUTW+I Content-Type: text/plain; charset=US-ASCII Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi all, On Fri, 12 Feb 2010 13:51:12 +0900 "Jun'ichi Nomura" wrote: > > So the bug seems introduced between next-20100205 and next-20100208. >=20 > Isn't this change missing the equivalent of "dput(old)"? >=20 > In patch-v2.6.33-rc7-next-20100208: > > diff --git a/fs/namei.c b/fs/namei.c > > index 94a5e60..a056dad 100644 > > --- a/fs/namei.c > > +++ b/fs/namei.c > > @@ -689,33 +689,17 @@ static __always_inline void follow_dotdot(struct = nameidata *nd) > ... > > - spin_lock(&dcache_lock); > > if (nd->path.dentry !=3D nd->path.mnt->mnt_root) { > > - nd->path.dentry =3D dget(nd->path.dentry->d_par= ent); > > - spin_unlock(&dcache_lock); > > - dput(old); > > + /* rare case of legitimate dget_parent()... */ > > + nd->path.dentry =3D dget_parent(nd->path.dentry= ); > > break; > > } That is part of commit 12578f932a8ad5f01bbf957d9c941760ef0dc575 ("Clean follow_dotdot() up a bit") from the vfs tree. --=20 Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ --Signature=_Fri__12_Feb_2010_16_30_42_+1100_EI7capKdFqWUTW+I Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iEYEARECAAYFAkt054IACgkQjjKRsyhoI8z9GQCgltc6fMqphIlmMAGEK5nIgNoT DXoAn2oOV/HE4Cb/sd7dzahyuvDMdneh =dyUk -----END PGP SIGNATURE----- --Signature=_Fri__12_Feb_2010_16_30_42_+1100_EI7capKdFqWUTW+I-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/