Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755905Ab0BLWzg (ORCPT ); Fri, 12 Feb 2010 17:55:36 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:53615 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751403Ab0BLWzf (ORCPT ); Fri, 12 Feb 2010 17:55:35 -0500 Date: Fri, 12 Feb 2010 14:54:40 -0800 From: Andrew Morton To: Jason Wessel Cc: linux-kernel@vger.kernel.org, kgdb-bugreport@lists.sourceforge.net, mingo@elte.hu, Randy Dunlap Subject: Re: [PATCH 22/28] printk,kdb: capture printk() when in kdb shell Message-Id: <20100212145440.7f0c68d0.akpm@linux-foundation.org> In-Reply-To: <1266014143-29444-23-git-send-email-jason.wessel@windriver.com> References: <1266014143-29444-1-git-send-email-jason.wessel@windriver.com> <1266014143-29444-23-git-send-email-jason.wessel@windriver.com> X-Mailer: Sylpheed 2.4.8 (GTK+ 2.12.5; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 951 Lines: 41 On Fri, 12 Feb 2010 16:35:37 -0600 Jason Wessel wrote: > @@ -609,6 +610,14 @@ asmlinkage int printk(const char *fmt, ...) > va_list args; > int r; > > +#ifdef CONFIG_KGDB_KDB > + if (unlikely(kdb_trap_printk)) { > + va_start(args, fmt); > + r = vkdb_printf(fmt, args); > + va_end(args); > + return r; > + } > +#endif > va_start(args, fmt); > r = vprintk(fmt, args); > va_end(args); this? --- a/kernel/printk.c~a +++ a/kernel/printk.c @@ -594,7 +594,11 @@ asmlinkage int printk(const char *fmt, . int r; va_start(args, fmt); +#ifdef CONFIG_KGDB_KDB + r = vkdb_printf(fmt, args); +#else r = vprintk(fmt, args); +#endif va_end(args); return r; _ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/