Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755404Ab0BOL3m (ORCPT ); Mon, 15 Feb 2010 06:29:42 -0500 Received: from cantor2.suse.de ([195.135.220.15]:41787 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755052Ab0BOL3l (ORCPT ); Mon, 15 Feb 2010 06:29:41 -0500 Date: Mon, 15 Feb 2010 12:29:50 +0100 From: Jan Kara To: Richard Kennedy Cc: Matthew Wilcox , Al Viro , Andrew Morton , Jan Kara , Christoph Hellwig , lkml , linux-fsdevel , Jens Axboe Subject: Re: [PATCH] fs: inode - remove 8 bytes of padding on 64bits allowing 1 more objects/slab under slub Message-ID: <20100215112950.GB4194@quack.suse.cz> References: <1266232571.2149.10.camel@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1266232571.2149.10.camel@localhost> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1395 Lines: 48 On Mon 15-02-10 11:16:11, Richard Kennedy wrote: > This removes 8 bytes of padding from struct inode on 64bit builds, and > so allows 1 more object/slab in the inode_cache when using slub. > > Signed-off-by: Richard Kennedy Looks good to me. Acked-by: Jan Kara Honza > ---- > patch against 2.6.33-rc8 > compiled & tested on x86_64 AMDX2 > > I've been running this patch for over a week with no obvious problems > regards > Richard > > > diff --git a/include/linux/fs.h b/include/linux/fs.h > index b1bcb27..ebb1cd5 100644 > --- a/include/linux/fs.h > +++ b/include/linux/fs.h > @@ -729,6 +729,7 @@ struct inode { > uid_t i_uid; > gid_t i_gid; > dev_t i_rdev; > + unsigned int i_blkbits; > u64 i_version; > loff_t i_size; > #ifdef __NEED_I_SIZE_ORDERED > @@ -738,7 +739,6 @@ struct inode { > struct timespec i_mtime; > struct timespec i_ctime; > blkcnt_t i_blocks; > - unsigned int i_blkbits; > unsigned short i_bytes; > umode_t i_mode; > spinlock_t i_lock; /* i_blocks, i_bytes, maybe i_size */ > > -- Jan Kara SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/