Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756027Ab0BOSVW (ORCPT ); Mon, 15 Feb 2010 13:21:22 -0500 Received: from mail-bw0-f213.google.com ([209.85.218.213]:44737 "EHLO mail-bw0-f213.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755383Ab0BOSVV (ORCPT ); Mon, 15 Feb 2010 13:21:21 -0500 X-Greylist: delayed 463 seconds by postgrey-1.27 at vger.kernel.org; Mon, 15 Feb 2010 13:20:50 EST DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=UZrW6HPzRYZW3zR2T+VzTZCk9WfBxt/DeEFmBBxoErHhIwCRYLyrakv0oBCj4G32XJ Ppr0eLyzAp8b58wwC6yXRQ+PT9uILOJ8jougHRZ9InmmN0cUAGYEv9sTuB0bQKDeVcIr CBIY3k7AMwydNFt9mA+aW4BmbFiqJ+L/pIpFo= Date: Mon, 15 Feb 2010 21:21:17 +0300 From: Cyrill Gorcunov To: Don Zickus , Ingo Molnar , linux-kernel@vger.kernel.org, peterz@infradead.org, aris@redhat.com, Frederic Weisbecker Subject: Re: [PATCH 1/4] nmi_watchdog: use a boolean config flag for compiling Message-ID: <20100215182117.GC5119@lenovo> References: <1266013161-31197-1-git-send-email-dzickus@redhat.com> <20100214165941.GA26329@elte.hu> <20100215175106.GM3062@redhat.com> <20100215181301.GB5119@lenovo> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100215181301.GB5119@lenovo> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1076 Lines: 28 On Mon, Feb 15, 2010 at 09:13:01PM +0300, Cyrill Gorcunov wrote: ... > > Looking through the code, is there ever case where 'apic' is undefined? > > The arch_trigger_all_cpu_backtrace should match identically to the old nmi > > code, so I am stuck on how to fix this. > > > > Thoughts? > > > > It looks familiar to one problem with HW breakpoints "Kconfig select" > issue Frederic fixed once not that long ago, if I recall correctly. > > So due to select we choose to compile hw_nmi.c, but CONFIG_LOCAL_APIC > (or APIC on UP) is turned off. So apic.c is not compiled. And at stage > of linking we get unresolved symbol. > > I don't remember the details how Frederic fixed HW breakpoints "select" > issue, CC'ed :) But you may google to find it out. > Here is what I mean http://patchwork.kernel.org/patch/67973/ -- Cyrill -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/