Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932653Ab0BPHD7 (ORCPT ); Tue, 16 Feb 2010 02:03:59 -0500 Received: from smtp-out.google.com ([216.239.44.51]:38732 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932643Ab0BPHD4 (ORCPT ); Tue, 16 Feb 2010 02:03:56 -0500 DomainKey-Signature: a=rsa-sha1; s=beta; d=google.com; c=nofws; q=dns; h=date:from:x-x-sender:to:cc:subject:in-reply-to:message-id: references:user-agent:mime-version:content-type:x-system-of-record; b=SLlN0JsL3TTz52SUIO1THR0IptL91535P0hoO+Am/yLwpY8DQnVXFvv/yGepbziO/ BtIJqFT1xwhYmTrGVBPDw== Date: Mon, 15 Feb 2010 23:03:50 -0800 (PST) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: KAMEZAWA Hiroyuki cc: Andrew Morton , Rik van Riel , Nick Piggin , Andrea Arcangeli , Balbir Singh , Lubos Lunak , KOSAKI Motohiro , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [patch] mm: add comment about deprecation of __GFP_NOFAIL In-Reply-To: <20100216102626.5f6f0e11.kamezawa.hiroyu@jp.fujitsu.com> Message-ID: References: <20100216085706.c7af93e1.kamezawa.hiroyu@jp.fujitsu.com> <20100216092147.85ef7619.kamezawa.hiroyu@jp.fujitsu.com> <20100216102626.5f6f0e11.kamezawa.hiroyu@jp.fujitsu.com> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 867 Lines: 18 On Tue, 16 Feb 2010, KAMEZAWA Hiroyuki wrote: > I hope no 3rd vendor (proprietary) driver uses __GFP_NOFAIL, they tend to > believe API is trustable and unchanged. > I hope they don't use it with GFP_ATOMIC, either, because it's never been respected in that context. We can easily audit the handful of cases in the kernel that use __GFP_NOFAIL (it takes five minutes at the max) and prove that none use it with GFP_ATOMIC or GFP_NOFS. We don't need to add multitudes of warnings about using a deprecated flag with ludicrous combinations (does anyone really expect GFP_ATOMIC | __GFP_NOFAIL to work gracefully)? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/