Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756766Ab0BPJEx (ORCPT ); Tue, 16 Feb 2010 04:04:53 -0500 Received: from smtp-out.google.com ([216.239.33.17]:12174 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756375Ab0BPJEu (ORCPT ); Tue, 16 Feb 2010 04:04:50 -0500 DomainKey-Signature: a=rsa-sha1; s=beta; d=google.com; c=nofws; q=dns; h=date:from:x-x-sender:to:cc:subject:in-reply-to:message-id: references:user-agent:mime-version:content-type:x-system-of-record; b=nTHkq0eAGBtT31AJeZBSc5bEimaUdD9rhfXPSG9XF/jLr+oLb7kGvEcdIORQUQ5qC 4x6FEDKNMz9BvAw3Jljpw== Date: Tue, 16 Feb 2010 01:04:44 -0800 (PST) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: KOSAKI Motohiro cc: Andrew Morton , Rik van Riel , KAMEZAWA Hiroyuki , Nick Piggin , Andrea Arcangeli , Balbir Singh , Lubos Lunak , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [patch 5/7 -mm] oom: replace sysctls with quick mode In-Reply-To: <20100216141539.72EF.A69D9226@jp.fujitsu.com> Message-ID: References: <20100215170634.729E.A69D9226@jp.fujitsu.com> <20100216141539.72EF.A69D9226@jp.fujitsu.com> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 969 Lines: 21 On Tue, 16 Feb 2010, KOSAKI Motohiro wrote: > > > "_quick" is always bad sysctl name. > > > > Why? It does exactly what it says: it kills current without doing an > > expensive tasklist scan and suppresses the possibly long tasklist dump. > > That's the oom killer's "quick mode." > > Because, an administrator think "_quick" implies "please use it always". > plus, "quick" doesn't describe clealy meanings. oom_dump_tasks does. > The audience for both of these tunables (now that oom_dump_tasks is default to enabled) is users with extremely long tasklists that want to avoid those scans, so oom_kill_quick implies that it won't waste any time and will act how it's documented: simply kill current and move on. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/