Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756794Ab0BPJLF (ORCPT ); Tue, 16 Feb 2010 04:11:05 -0500 Received: from smtp.nokia.com ([192.100.122.233]:56207 "EHLO mgw-mx06.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756773Ab0BPJK4 (ORCPT ); Tue, 16 Feb 2010 04:10:56 -0500 Subject: Re: [PATCH] mtd: misplaced parenthesis in find_boot_record() From: Artem Bityutskiy Reply-To: dedekind1@gmail.com To: Roel Kluin Cc: David Woodhouse , linux-mtd@lists.infradead.org, Andrew Morton , LKML In-Reply-To: <4B79C444.8090402@gmail.com> References: <4B79C344.60908@gmail.com> <4B79C444.8090402@gmail.com> Content-Type: text/plain; charset="UTF-8" Date: Tue, 16 Feb 2010 11:09:29 +0200 Message-ID: <1266311369.11659.201.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.28.2 (2.28.2-1.fc12) Content-Transfer-Encoding: 8bit X-OriginalArrivalTime: 16 Feb 2010 09:10:33.0554 (UTC) FILETIME=[E4F6D320:01CAAEE7] X-Nokia-AV: Clean Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1175 Lines: 31 On Mon, 2010-02-15 at 23:01 +0100, Roel Kluin wrote: > The parenthesis was misplaced > > Signed-off-by: Roel Kluin > --- > Not sure if you care about this one, it is between #if 0 ... #endif > > diff --git a/drivers/mtd/nftlmount.c b/drivers/mtd/nftlmount.c > index 8b22b18..1ae6a02 100644 > --- a/drivers/mtd/nftlmount.c > +++ b/drivers/mtd/nftlmount.c > @@ -109,7 +109,7 @@ static int find_boot_record(struct NFTLrecord *nftl) > > /* Finally reread to check ECC */ > if ((ret = mtd->read(mtd, block * nftl->EraseSize, SECTORSIZE, > - &retlen, buf) < 0)) { > + &retlen, buf)) < 0) { > printk(KERN_NOTICE "ANAND header found at 0x%x in mtd%d, but ECC read failed (err %d)\n", > block * nftl->EraseSize, nftl->mbd.mtd->index, ret); > continue; Pushed both patches to my l2-mtd-2.6.git / master. -- Best Regards, Artem Bityutskiy (Артём Битюцкий) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/