Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933382Ab0BPV1L (ORCPT ); Tue, 16 Feb 2010 16:27:11 -0500 Received: from ixro-out-rtc.ixiacom.com ([92.87.192.98]:2100 "EHLO ixro-ex1.ixiacom.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933307Ab0BPV1J (ORCPT ); Tue, 16 Feb 2010 16:27:09 -0500 From: Octavian Purdila Organization: Ixia To: "Eric W. Biederman" Subject: Re: [net-next PATCH v4 0/3] net: reserve ports for applications using fixed port Date: Tue, 16 Feb 2010 23:22:13 +0200 User-Agent: KMail/1.12.2 (Linux/2.6.32-2-686; KDE/4.3.2; i686; ; ) Cc: David Miller , Linux Kernel Network Developers , Linux Kernel Developers , Amerigo Wang , Eric Dumazet References: <1266271241-6293-1-git-send-email-opurdila@ixiacom.com> <201002162151.04861.opurdila@ixiacom.com> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-Id: <201002162322.13101.opurdila@ixiacom.com> X-OriginalArrivalTime: 16 Feb 2010 21:25:43.0256 (UTC) FILETIME=[98653580:01CAAF4E] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1341 Lines: 40 On Tuesday 16 February 2010 22:08:13 you wrote: > > Something like bellow? > > > > # set bits 8080 and 1666 > > $echo 8080 1666-1666 > /proc > > > > #reset bit 1666 > > $echo 8080 > /proc > > > > #reset whole bitmap > > $echo > /proc > > Yes. So something like that. > > I think I would use commas instead of spaces as that is more traditional. > OK, I was trying to reuse the existing skip whitespace code :) but if you think its cleaner with commas I can do that. > > Note that this new proc entry will work in conjunction with the existing > > ip_local_port_range option, so the default bitmap can (and should be) > > empty. > > Do we want userspace to see this implementation detail? Two data structures > doing the almost the same thing could get confusing in a hurry. It feels > like a recipe for changing one and not the other and then running around > trying to figure out why the change did not work. > Yes, I believe we want to have reserved_ports contain just those special ports that the user wants to reserve. After all we add this entry for this specific purpose. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/