Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933394Ab0BPVwa (ORCPT ); Tue, 16 Feb 2010 16:52:30 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:33652 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933341Ab0BPVw1 (ORCPT ); Tue, 16 Feb 2010 16:52:27 -0500 Date: Tue, 16 Feb 2010 13:51:46 -0800 From: Andrew Morton To: Guennadi Liakhovetski Cc: linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, Ian Molton , Magnus Damm , "linux-sh@vger.kernel.org" Subject: Re: [PATCH] tmio_mmc: keep card-detect interrupts enabled Message-Id: <20100216135146.beacf701.akpm@linux-foundation.org> In-Reply-To: References: <20091217131239.0dfd5534.akpm@linux-foundation.org> X-Mailer: Sylpheed 2.4.8 (GTK+ 2.12.9; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2625 Lines: 60 On Tue, 16 Feb 2010 10:34:55 +0100 (CET) Guennadi Liakhovetski wrote: > On SuperH platforms the SDHI controller does not produce any command IRQs after > a completed IO. This leads to card-detect interrupts staying disabled. Do not > disable card-detect interrupts on DATA IRQs. > Why is the current code disabling card-detect interrupts on DATA IRQs? Was that just a bug? What effect will this change have for current users of this driver? > --- > On Thu, 17 Dec 2009, Andrew Morton wrote: > > > On Thu, 17 Dec 2009 21:25:52 +0100 (CET) > > Guennadi Liakhovetski wrote: > > > > > I originally submitted this [1] patch on the 6th of November, then > > > accidentally the MMC list got dropped from CC and the discussion moved to > > > another irrelevant list, Ian's last reply is at [2]. Unfortunately, Ian > > > hasn't replied to my reminders since then, and I don't see this patch > > > anywhere upstream. Is there any way we could get it into 2.6.33? > > > > Please redo and retest it against curent mainline and do a full resend. > > Re-testing this patch has again become possible now, after Magnus has > posted his INTC and the "tmio_mmc: use 100ms mmc_detect_change() delay" > patches. Successfully tested on Migo-R (sh7722) and MS7724SE (sh7724). > Andrew, please apply. > > drivers/mmc/host/tmio_mmc.h | 6 ++---- > 1 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/mmc/host/tmio_mmc.h b/drivers/mmc/host/tmio_mmc.h > index 692dc23..dafecfb 100644 > --- a/drivers/mmc/host/tmio_mmc.h > +++ b/drivers/mmc/host/tmio_mmc.h > @@ -55,10 +55,8 @@ > /* Define some IRQ masks */ > /* This is the mask used at reset by the chip */ > #define TMIO_MASK_ALL 0x837f031d > -#define TMIO_MASK_READOP (TMIO_STAT_RXRDY | TMIO_STAT_DATAEND | \ > - TMIO_STAT_CARD_REMOVE | TMIO_STAT_CARD_INSERT) > -#define TMIO_MASK_WRITEOP (TMIO_STAT_TXRQ | TMIO_STAT_DATAEND | \ > - TMIO_STAT_CARD_REMOVE | TMIO_STAT_CARD_INSERT) > +#define TMIO_MASK_READOP (TMIO_STAT_RXRDY | TMIO_STAT_DATAEND) > +#define TMIO_MASK_WRITEOP (TMIO_STAT_TXRQ | TMIO_STAT_DATAEND) > #define TMIO_MASK_CMD (TMIO_STAT_CMDRESPEND | TMIO_STAT_CMDTIMEOUT | \ > TMIO_STAT_CARD_REMOVE | TMIO_STAT_CARD_INSERT) > #define TMIO_MASK_IRQ (TMIO_MASK_READOP | TMIO_MASK_WRITEOP | TMIO_MASK_CMD) > -- > 1.6.2.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/