Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933642Ab0BPXyh (ORCPT ); Tue, 16 Feb 2010 18:54:37 -0500 Received: from hera.kernel.org ([140.211.167.34]:43398 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932771Ab0BPXyf (ORCPT ); Tue, 16 Feb 2010 18:54:35 -0500 Message-ID: <4B7B2FE1.1030700@kernel.org> Date: Tue, 16 Feb 2010 15:53:05 -0800 From: Yinghai Lu User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091130 SUSE/3.0.0-1.1.1 Thunderbird/3.0 MIME-Version: 1.0 To: "H. Peter Anvin" CC: Stephen Rothwell , Ingo Molnar , Thomas Gleixner , Andrew Morton , Linus Torvalds , Jesse Barnes , Christoph Lameter , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org Subject: Re: [PATCH 27/35] core: move early_res References: <1265793639-15071-1-git-send-email-yinghai@kernel.org> <1265793639-15071-28-git-send-email-yinghai@kernel.org> <20100215011615.e3d35121.sfr@canb.auug.org.au> <4B786110.9020806@kernel.org> <4B7B2E3B.9060903@zytor.com> In-Reply-To: <4B7B2E3B.9060903@zytor.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 924 Lines: 32 On 02/16/2010 03:46 PM, H. Peter Anvin wrote: > On 02/14/2010 12:46 PM, Yinghai Lu wrote: >> >> please check >> >> Subject: [PATCH -v2] x86: fix cross-arch compiling >> >> Ingo found: >> lots of cross-arch build failures in latest -tip: >> >> >> +u64 __init __weak get_max_mapped(void) >> +{ >> + panic("should have get_max_mapped defined with arch"); >> + >> + return -1ULL; >> +} >> + > > All this does would seem is it would change a build failure into a > runtime panic. I really fail to see how this is an improvement... current only x86 support to early_res replace bootmem. later if other arch is using that feature, it need to provide that get_max_mapped. Yinghai -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/