Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755845Ab0BQL1f (ORCPT ); Wed, 17 Feb 2010 06:27:35 -0500 Received: from mail-bw0-f219.google.com ([209.85.218.219]:48166 "EHLO mail-bw0-f219.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752340Ab0BQL1d (ORCPT ); Wed, 17 Feb 2010 06:27:33 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=bEk+K/7jy3K1TYjZA5d6SphpTeXeZaguAH34f+liJzYMrGUXahFfJe6ztJo3ge5ycM /QGZ+FUcD/+J8SiP037VK+L9kN66Pf1R8alxpAcnV3/58OUz9aGZQht/5HQTSlEIaRu+ fO0IDVUWv0ts4mn3HUC3Wrbd2SuWkDxyzRTa4= MIME-Version: 1.0 In-Reply-To: <201002162216.30192.rjw@sisk.pl> References: <9b2b86521001020703v23152d0cy3ba2c08df88c0a79@mail.gmail.com> <9b2b86521002160309g26d60bd2t4c19bd2294b76c28@mail.gmail.com> <9b2b86521002160712r39ecb2b1q5e01389e9209e17b@mail.gmail.com> <201002162216.30192.rjw@sisk.pl> Date: Wed, 17 Feb 2010 11:27:30 +0000 Message-ID: <9b2b86521002170327m1f08ff73ncca9e5eff77b1966@mail.gmail.com> Subject: Re: s2disk hang update From: Alan Jenkins To: "Rafael J. Wysocki" Cc: Mel Gorman , hugh.dickins@tiscali.co.uk, Pavel Machek , pm list , linux-kernel , Kernel Testers List Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2240 Lines: 59 On 2/16/10, Rafael J. Wysocki wrote: > On Tuesday 16 February 2010, Alan Jenkins wrote: >> On 2/16/10, Alan Jenkins wrote: >> > On 2/15/10, Rafael J. Wysocki wrote: >> >> On Tuesday 09 February 2010, Alan Jenkins wrote: >> >>> Perhaps I spoke too soon. I see the same hang if I run too many >> >>> applications. The first hibernation fails with "not enough swap" as >> >>> expected, but the second or third attempt hangs (with the same >> >>> backtrace >> >>> as before). >> >>> >> >>> The patch definitely helps though. Without the patch, I see a hang >> >>> the >> >>> first time I try to hibernate with too many applications running. >> >> >> >> Well, I have an idea. >> >> >> >> Can you try to apply the appended patch in addition and see if that >> >> helps? >> >> >> >> Rafael >> > >> > It doesn't seem to help. >> >> To be clear: It doesn't stop the hang when I hibernate with too many >> applications. >> >> It does stop the same hang in a different case though. >> >> 1. boot with init=/bin/bash >> 2. run s2disk >> 3. cancel the s2disk >> 4. repeat steps 2&3 >> >> With the patch, I can run 10s of iterations, with no hang. >> Without the patch, it soon hangs, (in disable_nonboot_cpus(), as always). >> >> That's what happens on 2.6.33-rc7. On 2.6.30, there is no problem. >> On 2.6.31 and 2.6.32 I don't get a hang, but dmesg shows an allocation >> failure after a couple of iterations ("kthreadd: page allocation >> failure. order:1, mode:0xd0"). It looks like it might be the same >> stop_machine thread allocation failure that causes the hang. > > Have you tested it alone or on top of the previous one? If you've tested it > alone, please apply the appended one in addition to it and retest. > > Rafael I did test with both patches applied together - 1. [Update] MM / PM: Force GFP_NOIO during suspend/hibernation and resume 2. "reducing the number of pages that we're going to keep preallocated by 20%" Alan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/