Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751923Ab0BQQQ2 (ORCPT ); Wed, 17 Feb 2010 11:16:28 -0500 Received: from mx1.redhat.com ([209.132.183.28]:29325 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751393Ab0BQQQ0 (ORCPT ); Wed, 17 Feb 2010 11:16:26 -0500 Message-ID: <4B7C1722.7040304@redhat.com> Date: Thu, 18 Feb 2010 00:19:46 +0800 From: Cong Wang User-Agent: Thunderbird 2.0.0.23 (X11/20091001) MIME-Version: 1.0 To: "Eric W. Biederman" CC: Octavian Purdila , David Miller , Linux Kernel Network Developers , Linux Kernel Developers , Eric Dumazet Subject: Re: [net-next PATCH v4 0/3] net: reserve ports for applications using fixed port References: <1266271241-6293-1-git-send-email-opurdila@ixiacom.com> <201002162151.04861.opurdila@ixiacom.com> <201002162322.13101.opurdila@ixiacom.com> <4B7C11D4.1080309@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1654 Lines: 63 Eric W. Biederman wrote: > Cong Wang writes: > >> Octavian Purdila wrote: >>> On Tuesday 16 February 2010 22:08:13 you wrote: >>>>> Something like bellow? >>>>> >>>>> # set bits 8080 and 1666 >>>>> $echo 8080 1666-1666 > /proc >>>>> >>>>> #reset bit 1666 >>>>> $echo 8080 > /proc >>>>> >>>>> #reset whole bitmap >>>>> $echo > /proc >>>> Yes. So something like that. >>>> >>>> I think I would use commas instead of spaces as that is more traditional. >> >> Why this is better than the current version? >> >> For the single port case, currently we use: >> >> echo +8080 > /xxxx #set >> echo -8080 > /xxxx #clear >> >> Now we will use: >> >> echo 8080 > /xxxx #set >> echo 8080 > /xxxx #clear > > No. > >> I don't think the latter is better... >> >> For the multi-port case, yes, we should accept 'echo 8080,10000 >/xxxx'. > > What I was envisioning was: > > echo 8080 > /xxx # set the bitmap to 8080 > echo 8080,10000 > /xxx # add 10000 to the bitmap > echo 8080 > /xxxx # remove 10000 from the bitmap. > > That is when you set it you enter the entire set every time, treating > the entire set as a single value. > Oh, I see, this is ok. But if we could support multi-port, that will be better, something like: echo '8080,10000-11000' > /xxx #add port 8080 and port range 10000-11000 so that I don't have to construct a long string for all ports within 10000 and 11000. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/