Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Fri, 19 Apr 2002 18:37:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Fri, 19 Apr 2002 18:37:54 -0400 Received: from lightning.swansea.linux.org.uk ([194.168.151.1]:31749 "EHLO the-village.bc.nu") by vger.kernel.org with ESMTP id ; Fri, 19 Apr 2002 18:36:35 -0400 Subject: Re: [PATCH] 2.4.19-pre7 New Driver synclink_cs.c To: paulkf@microgate.com (Paul Fulghum) Date: Fri, 19 Apr 2002 23:54:36 +0100 (BST) Cc: marcelo@conectiva.com.br, linux-kernel@vger.kernel.org In-Reply-To: <1019239480.1139.1.camel@diemos.microgate.com> from "Paul Fulghum" at Apr 19, 2002 01:04:39 PM X-Mailer: ELM [version 2.5 PL6] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-Id: From: Alan Cox Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org > This patch is against 2.4.19-pre7 > Please apply. Can you fix the random global variables and the mysterious "this function feels like 4 space tab, this one 8 space" bits. Mostly the global. A MODULE_PARM() doesn't need to be global - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/