Date: Thu, 18 Feb 2010 10:41:57 +0200 (EET)
From: "=?ISO-8859-15?Q?Ilpo_J=E4rvinen?=" <ilpo.jarvinen@helsinki.fi>
To: apetlund@simula.no
cc: Netdev <netdev@vger.kernel.org>, eric.dumazet@gmail.com,
       hannemann@nets.rwth-aachen.de, LKML <linux-kernel@vger.kernel.org>,
       shemminger@vyatta.com, william.allen.simpson@gmail.com,
       damian@tvk.rwth-aachen.de, ebiederm@xmission.com,
       David Miller <davem@davemloft.net>
Subject: Re: [net-next PATCH v4 2/3] net: TCP thin linear timeouts
In-Reply-To: <20100217.163255.133898079.davem@davemloft.net>
Message-ID: <alpine.DEB.2.00.1002181040520.9961@melkinpaasi.cs.helsinki.fi>
References: <4B7AAE69.8020701@simula.no> <20100217.163255.133898079.davem@davemloft.net>
User-Agent: Alpine 2.00 (DEB 1167 2008-08-23)
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 954
Lines: 29

On Wed, 17 Feb 2010, David Miller wrote:

> From: Andreas Petlund <apetlund@simula.no>
> Date: Tue, 16 Feb 2010 15:40:41 +0100
> 
> > @@ -341,6 +342,8 @@ struct tcp_sock {
> >  	u16	advmss;		/* Advertised MSS			*/
> >  	u8	frto_counter;	/* Number of new acks after RTO */
> >  	u8	nonagle;	/* Disable Nagle algorithm?             */
> > +	u8      thin_lto    : 1,/* Use linear timeouts for thin streams */
> > +		thin_undef  : 7;
> >  
> 
> There is now a gap of 3 unused bytes here in this critical
> core TCP socket data structure.
> 
> Please either find a way to avoid this hole, or document
> it with a comment.

There would be multiple bits free for use in both frto_counter and nonagle 
byte.

-- 
 i.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/