Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754042Ab0BRJ3R (ORCPT ); Thu, 18 Feb 2010 04:29:17 -0500 Received: from one.firstfloor.org ([213.235.205.2]:50281 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751509Ab0BRJ3O (ORCPT ); Thu, 18 Feb 2010 04:29:14 -0500 Date: Thu, 18 Feb 2010 10:29:07 +0100 From: Andi Kleen To: Zachary Amsden Cc: Andi Kleen , "H. Peter Anvin" , Linus Torvalds , linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , x86@kernel.org, Avi Kivity Subject: Re: [PATCH] x86 rwsem optimization extreme Message-ID: <20100218092907.GC5964@basil.fritz.box> References: <1266443901-3646-1-git-send-email-zamsden@redhat.com> <4B7C7BE4.9050908@zytor.com> <4B7C9F0A.1080708@zytor.com> <4B7CC14F.7000802@redhat.com> <87iq9v55em.fsf@basil.nowhere.org> <4B7CF95A.4040706@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4B7CF95A.4040706@redhat.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 973 Lines: 28 On Wed, Feb 17, 2010 at 10:24:58PM -1000, Zachary Amsden wrote: >> >> Zachary Amsden writes >>> Incidentally, the cost of putting all the rwsem code inline, using the >>> straightforward approach, for git-tip, using defconfig on x86_64 is >>> 3565 bytes / 20971778 bytes total, or 0.0168%, using gcc 4.4.3. >>> >> The nice advantage of putting lock code inline is that it gets >> accounted to the caller in all profilers. >> >> -Andi >> >> > > Unfortunately, only for the uncontended case. The hot case still ends up > in a call to the lock text section. I removed those some time ago because it breaks unwinding. Did that get undone? -Andi -- ak@linux.intel.com -- Speaking for myself only. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/