Date: Thu, 18 Feb 2010 14:21:12 +0100
Message-ID: <s5htytellx3.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Ed Tomlinson <edt@aei.ca>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>, linux-kernel@vger.kernel.org,
       alsa-devel@alsa-project.org
Subject: Re: [LOCKDEP] 33-rc8 Running aplay with pulse as the default
In-Reply-To: <201002180725.38635.edt@aei.ca>
References: <alpine.LFD.2.00.1002121142100.3922@localhost.localdomain>
	<201002170816.33209.edt@aei.ca>
	<s5heikkndf2.wl%tiwai@suse.de>
	<201002180725.38635.edt@aei.ca>
User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.1
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1671
Lines: 42

At Thu, 18 Feb 2010 07:25:38 -0500,
Ed Tomlinson wrote:
> 
> On Wednesday 17 February 2010 09:29:37 Takashi Iwai wrote:
> > At Wed, 17 Feb 2010 08:16:32 -0500,
> > Ed Tomlinson wrote:
> > > 
> > > On Tuesday 16 February 2010 08:37:46 Takashi Iwai wrote:
> > > > > Thanks for the patch.  It helps in that it eliminates the opps but lockdep still triggers and aplay still fails.  
> > > > > Here is the new traceback.
> > > > 
> > > > Hmm, fixing this isn't so trivial.  The same problem occurs on other
> > > > subsystems like NFS over years.  And it's still there, AFAIK.
> > > > The mmap mutex appears suddenly in the strange code path at close.
> > > > 
> > > > The patch below might fix, but I'm not 100% sure whether this has no
> > > > side effect.
> > > > 
> > > > Anyway, I doubt very much it being a regression.  There is no change
> > > > in ALSA core side, and also in V4L em28xx code.  Maybe the lockdep
> > > > wasn't triggered by some reason.  And, this lockdep warning is almost
> > > > harmless...
> > > 
> > > Takashi,
> > > 
> > > The second patch eliminating the lock causes oppes every time (one follows just in case
> > > its helpful).
> > 
> > Are you sure?  The patch should causes a compile error, so you must have
> > patched manually in a wrong place ;)
> 
> Yes I am sure.  I fixed the compile error the same way it is fixed below.

But the Oops looks pretty irrelevant from the code path.


Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/