Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758640Ab0BRRyK (ORCPT ); Thu, 18 Feb 2010 12:54:10 -0500 Received: from cantor2.suse.de ([195.135.220.15]:44300 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758057Ab0BRRyI (ORCPT ); Thu, 18 Feb 2010 12:54:08 -0500 Date: Thu, 18 Feb 2010 09:51:51 -0800 From: Greg KH To: Florian Mickler Cc: Tim Schofield , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, tim@weberpafrica.com Subject: Re: [PATCH] Staging:rtl8192e: fix comments style issue in r8180_93cx6.c This is a patch to the r8180_93cx6.c file that fixes up the comments styling issues found by the checkpatch.pl tool Signed-off-by: Tim Schofield Message-ID: <20100218175151.GB24560@suse.de> References: <1266338116-27482-1-git-send-email-tim@weberpafrica.com> <20100218160547.GJ21785@kroah.com> <20100218183151.4b7dbf72@schatten.dmk.lab> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100218183151.4b7dbf72@schatten.dmk.lab> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2047 Lines: 56 On Thu, Feb 18, 2010 at 06:31:51PM +0100, Florian Mickler wrote: > On Thu, 18 Feb 2010 08:05:47 -0800 > Greg KH wrote: > > > On Tue, Feb 16, 2010 at 04:35:16PM +0000, tim@weberpafrica.com wrote: > > > From: Tim Schofield > > > > > > --- > > > drivers/staging/rtl8192e/r8180_93cx6.c | 22 ++++++++++++++-------- > > > 1 files changed, 14 insertions(+), 8 deletions(-) > > > > > > diff --git a/drivers/staging/rtl8192e/r8180_93cx6.c b/drivers/staging/rtl8192e/r8180_93cx6.c > > > index 262ed5f..60fba80 100644 > > > --- a/drivers/staging/rtl8192e/r8180_93cx6.c > > > +++ b/drivers/staging/rtl8192e/r8180_93cx6.c > > > @@ -23,12 +23,14 @@ > > > static void eprom_cs(struct net_device *dev, short bit) > > > { > > > if (bit) > > > + /* enable EPROM */ > > > write_nic_byte(dev, EPROM_CMD, > > > (1< > > - read_nic_byte(dev, EPROM_CMD)); //enable EPROM > > > + read_nic_byte(dev, EPROM_CMD)); > > > else > > > + /* disable EPROM */ > > > write_nic_byte(dev, EPROM_CMD, read_nic_byte(dev, EPROM_CMD)\ > > > - &~(1< > > + &~(1< > > > This does not do what you think it does (hint, you need {} if you want > > to have more than one line in an if statement...) > > > > Can you always verify that your coding style changes do not actually > > break the code? A simple comparison of the .ko file before and after > > should be sufficient. > > > > thanks, > > > > greg k-h > > hm... no.. seems to be correct... the comment get's ignored. But I > agree that {} would be nicer to the eye... wow, you are right, I just tested it out, learn something new every day. But we should add braces... thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/