Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754710Ab0BRShy (ORCPT ); Thu, 18 Feb 2010 13:37:54 -0500 Received: from e5.ny.us.ibm.com ([32.97.182.145]:57383 "EHLO e5.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754149Ab0BRShw (ORCPT ); Thu, 18 Feb 2010 13:37:52 -0500 Date: Thu, 18 Feb 2010 10:37:50 -0800 From: "Darrick J. Wong" To: Muli Ben-Yehuda Cc: Ingo Molnar , "Jon D. Mason" , discuss@x86-64.org, Corinna Schultz , linux-kernel Subject: Re: [PATCH] calgary: Increase the maximum PHB bus number Message-ID: <20100218183750.GL29604@tux1.beaverton.ibm.com> Reply-To: djwong@us.ibm.com References: <20091209005901.GX10295@tux1.beaverton.ibm.com> <20091209090346.GN2452@tyrion.haifa.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091209090346.GN2452@tyrion.haifa.ibm.com> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1307 Lines: 32 On Wed, Dec 09, 2009 at 11:03:46AM +0200, Muli Ben-Yehuda wrote: > On Tue, Dec 08, 2009 at 04:59:01PM -0800, Darrick J. Wong wrote: > > > -#define MAX_NUM_OF_PHBS 8 /* how many PHBs in total? */ > > -#define MAX_NUM_CHASSIS 8 /* max number of chassis */ > > -/* MAX_PHB_BUS_NUM is the maximal possible dev->bus->number */ > > -#define MAX_PHB_BUS_NUM (MAX_NUM_OF_PHBS * MAX_NUM_CHASSIS * 2) > > +/* > > + The maximum PHB bus number. > > + x3950M2 (rare): 8 chassis, 48 PHBs per chassis = 384 > > + x3950M2: 4 chassis, 48 PHBs per chassis = 192 > > + x3950 (PCIE): 8 chassis, 32 PHBs per chassis = 256 > > + x3950 (PCIX): 8 chassis, 16 PHBs per chassis = 128 > > +*/ > > +#define MAX_PHB_BUS_NUM 384 > > + > > #define PHBS_PER_CALGARY 4 > > We'll end up wasting a few bytes on small systems, but I don't think > it's enough to matter on these fairly large systems. As far as I'm > concerned, patch is fine. > > Acked-by: Muli Ben-Yehuda Hmm... has this patch been queued up by anyone for the .34 merge window? --D -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/