Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752470Ab0BRU0W (ORCPT ); Thu, 18 Feb 2010 15:26:22 -0500 Received: from arroyo.ext.ti.com ([192.94.94.40]:43892 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750993Ab0BRU0U (ORCPT ); Thu, 18 Feb 2010 15:26:20 -0500 From: "Karicheri, Muralidharan" To: roel kluin CC: Mauro Carvalho Chehab , "linux-media@vger.kernel.org" , Andrew Morton , LKML Date: Thu, 18 Feb 2010 14:25:56 -0600 Subject: RE: [PATCH] video_device: don't free_irq() an element past array vpif_obj.dev[] and fix test Thread-Topic: [PATCH] video_device: don't free_irq() an element past array vpif_obj.dev[] and fix test Thread-Index: Acqw1VPjb5RciSatQOCIsbikCmIJ/wAAmKzg Message-ID: References: <4B714E15.4020909@gmail.com> <25e057c01002181202v346f488bk571d099f679fea83@mail.gmail.com> In-Reply-To: <25e057c01002181202v346f488bk571d099f679fea83@mail.gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by alpha.home.local id o1IKR5mE010947 Content-Length: 1289 Lines: 45 >>>-      if (!std_info) >>>+      if (!std_info->stdid) >>>               return -1; >>> >> This is a NACK. We shouldn't check for stdid since the function is >supposed >> to update std_info. So just remove >> >> if (!std_info) >>        return -1; > >I don't see how std_info could get updated. consider the loop in case >std_info->stdid equals 0: Ok. You are right! The ch_params[] is a table for keeping the information about different standards supported. For a given stdid in std_info, the function matches the stdid with that in the table and get the corresponding entry. >> I am okay with the below change. So please re-submit the patch with the >> above change and my ACK. >> >> Thanks >> >> Murali >> > >>>+      if (k == VPIF_DISPLAY_MAX_DEVICES) >>>+              k = VPIF_DISPLAY_MAX_DEVICES - 1; > >actually I think this is still not right. shouldn't it be be > >k = VPIF_DISPLAY_MAX_DEVICES - 1; What you mean here? What you suggest here is same as in your patch, right? Murali > >> are you using this driver in your project? > >No, I just found this in the code. > >Thanks, Roel ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?