Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753748Ab0BSPve (ORCPT ); Fri, 19 Feb 2010 10:51:34 -0500 Received: from gir.skynet.ie ([193.1.99.77]:41000 "EHLO gir.skynet.ie" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751621Ab0BSPvc (ORCPT ); Fri, 19 Feb 2010 10:51:32 -0500 Date: Fri, 19 Feb 2010 15:51:17 +0000 From: Mel Gorman To: Greg KH Cc: Andrea Arcangeli , Christoph Lameter , Adam Litke , Avi Kivity , David Rientjes , KOSAKI Motohiro , Rik van Riel , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 10/12] Add /sys trigger for per-node memory compaction Message-ID: <20100219155117.GC1445@csn.ul.ie> References: <1266516162-14154-1-git-send-email-mel@csn.ul.ie> <1266516162-14154-11-git-send-email-mel@csn.ul.ie> <20100219145358.GB24790@kroah.com> <20100219152830.GB1445@csn.ul.ie> <20100219153142.GA26557@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20100219153142.GA26557@kroah.com> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2332 Lines: 54 On Fri, Feb 19, 2010 at 07:31:42AM -0800, Greg KH wrote: > On Fri, Feb 19, 2010 at 03:28:30PM +0000, Mel Gorman wrote: > > On Fri, Feb 19, 2010 at 06:53:59AM -0800, Greg KH wrote: > > > On Thu, Feb 18, 2010 at 06:02:40PM +0000, Mel Gorman wrote: > > > > This patch adds a per-node sysfs file called compact. When the file is > > > > written to, each zone in that node is compacted. The intention that this > > > > would be used by something like a job scheduler in a batch system before > > > > a job starts so that the job can allocate the maximum number of > > > > hugepages without significant start-up cost. > > > > > > As you are adding sysfs files, can you please also add documentation for > > > the file in Documentation/ABI/ ? > > > > > > > I looked at this before and hit a wall and then forgot about it. I couldn't > > find *where* I should document it at the time. There isn't a sysfs-devices-node > > file to add to and much (all?) of what is in that branch appears undocumented. > > Well, you can always just document what you add, or you can document the > existing stuff as well. It's your choice :) > Fair point! I've taken note to document what's in there over time. For the moment, is this a reasonable start? I'll split it into two patches but the end result will be the same. diff --git a/Documentation/ABI/testing/sysfs-devices-node b/Documentation/ABI/testing/sysfs-devices-node new file mode 100644 index 0000000..1ee348b --- /dev/null +++ b/Documentation/ABI/testing/sysfs-devices-node @@ -0,0 +1,15 @@ +What: /sys/devices/system/node/nodeX +Date: October 2002 +Contact: Linux Memory Management list +Description: + When CONFIG_NUMA is enabled, this is a directory containing + information on node X such as what CPUs are local to the + node. + +What: /sys/devices/system/node/nodeX/compact +Date: February 2010 +Contact: Mel Gorman +Description: + When this file is written to, all memory within that node + will be compacted. When it completes, memory will be free + in as contiguous blocks as possible. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/